-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stub slurm test #2998
stub slurm test #2998
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2998 +/- ##
=======================================
Coverage 41.85% 41.85%
=======================================
Files 95 95
Lines 10535 10535
=======================================
Hits 4409 4409
Misses 6126 6126 ☔ View full report in Codecov by Sentry. |
I would propose to have it as a bash script that will submit a batch script, and thus having the following format for a command: I also would use our SRUN options here, such as |
That all makes sense, will implement. Thanks! |
bin/radical-pilot-test-slurm
Outdated
EOT | ||
|
||
echo sbatch /tmp/$$.slurm | ||
cat /tmp/$$.slurm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we actually submit this script? (as I understand this cat
just to debug PR, but with this command radical-pilot-test-slurm
we would want to submit batch script, right?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (with a comment above)
No description provided.