Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stub slurm test #2998

Merged
merged 7 commits into from
Sep 7, 2023
Merged

stub slurm test #2998

merged 7 commits into from
Sep 7, 2023

Conversation

andre-merzky
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.85%. Comparing base (13852db) to head (d3aafbf).
Report is 2382 commits behind head on devel.

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #2998   +/-   ##
=======================================
  Coverage   41.85%   41.85%           
=======================================
  Files          95       95           
  Lines       10535    10535           
=======================================
  Hits         4409     4409           
  Misses       6126     6126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mtitov
Copy link
Contributor

mtitov commented Jul 31, 2023

I would propose to have it as a bash script that will submit a batch script, and thus having the following format for a command: radical-pilot-test-slurm -a <account> -p <partition> [--exclusive]. The last parameter is to test an exclusive approach (--exclusive option in SBATCH and --exact option in SRUN) and which is optional (so we can test without it first, and then with it)

I also would use our SRUN options here, such as --nodes, --ntasks, --cpus-per-task, --mem 0, --nodelist (since we need to ensure all these options)

@andre-merzky
Copy link
Member Author

I would propose to have it as a bash script that will submit a batch script, and thus having the following format for a command: radical-pilot-test-slurm -a <account> -p <partition> [--exclusive]. The last parameter is to test an exclusive approach (--exclusive option in SBATCH and --exact option in SRUN) and which is optional (so we can test without it first, and then with it)

I also would use our SRUN options here, such as --nodes, --ntasks, --cpus-per-task, --mem 0, --nodelist (since we need to ensure all these options)

That all makes sense, will implement. Thanks!

EOT

echo sbatch /tmp/$$.slurm
cat /tmp/$$.slurm
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we actually submit this script? (as I understand this cat just to debug PR, but with this command radical-pilot-test-slurm we would want to submit batch script, right?)

Copy link
Contributor

@mtitov mtitov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (with a comment above)

@andre-merzky andre-merzky merged commit 574b3ea into devel Sep 7, 2023
20 checks passed
@andre-merzky andre-merzky deleted the feature/test_slurm branch September 7, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants