-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/darshan #661
Fix/darshan #661
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## devel #661 +/- ##
==========================================
+ Coverage 71.33% 71.46% +0.13%
==========================================
Files 23 26 +3
Lines 2114 2250 +136
==========================================
+ Hits 1508 1608 +100
- Misses 606 642 +36 ☔ View full report in Codecov by Sentry. |
todo:
|
@andre-merzky ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mtitov, the code looks reasonable to me.
What I am missing is some explanation what Darshan actually is and what it is used for. For example: some methods are public methods and will show up in RTD, but don't have a docstring, so the user is left guessing what this is about.
Updated Darshan integration based on the latest experience of using it