Fix memory leaks problems in t/local/11_read.t reported by Assress Sanitizer #498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is problem is detected when perl is build with Address Sanitizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you build perl (and consequently Net::SSLleay) using Address Sanitizer,
t/local/11_read.ttest will fail.This is because SSL_CTX are not properly freed when no longer in use. If you directly call SSL method of creating something, you should also directly free it, as you would do if you write pure C code.
This patch fixes the problem with the test. I guess that the necessity of calling Net::SSLeay::CTX_free should also be mentioned in docs. But I did not find proper place for putting it without bit rewriting.
You can find instruction on how to build perl in this modulet using ASan in #469
PS please refer me as NATARAJ (Nikolay Shaplov) if you ever would like to mention me anywhere...