Skip to content

Allow zero for retries and timeout in the configuration #102

@maersk-

Description

@maersk-

The rc_test_config() method does not allow retries and timeout values of zero. The following checks are made:

if (rc_conf_int(rh, "radius_timeout") <= 0)
{
   rc_log(LOG_ERR,"%s: radius_timeout <= 0 is illegal", filename);
   return -1;
}
if (rc_conf_int(rh, "radius_retries") <= 0)
{
   rc_log(LOG_ERR,"%s: radius_retries <= 0 is illegal", filename);
   return -1;
}

In my opinion using 0 and just checking <0 would be completely fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions