Skip to content

Conversation

@jt274
Copy link
Contributor

@jt274 jt274 commented Feb 13, 2025

- Fixes breaking change on Flutter 3.29.0
@KennyHuRadar
Copy link
Contributor

Thank you for creating this PR, I'll take a harder look at this as soon as I have some more time.
To facilitate the quick merging of this PR, could you reference the breaking change and also justify backwards compatibility along with "safety" of this change?
Thanks!

@jt274
Copy link
Contributor Author

jt274 commented Feb 15, 2025

This has been deprecated I believe since flutter 1.22. Here is some more relevant info:

https://docs.flutter.dev/release/breaking-changes/android-v1-embedding-create-deprecation
https://docs.google.com/document/d/1wKspwf6LQu6uo32uQ9NcukfiKhLL4ButV9cwpjeb8QI/edit?tab=t.0
flutter/flutter#160890

I see no other specific mention of this in the 3.29.0 release notes, but the release broke many plugins due to this same issue. I'm not able to spend any time verifying backwards compatibility or safety, but this fix has worked for me.

https://docs.flutter.dev/release/breaking-changes/plugin-api-migration

@Jonny1987
Copy link
Contributor

Jonny1987 commented Mar 2, 2025

Can this be reviewed @KennyHuRadar please? I can't increase my flutter version until this is fixed

@jt274
Copy link
Contributor Author

jt274 commented Mar 3, 2025

@Jonny1987 You can feel free to use my fork here until this is merged: https://github.com/jt274/flutter-radar/tree/flutter-plugin-interface

@KennyHuRadar
Copy link
Contributor

KennyHuRadar commented Mar 3, 2025

@Jonny1987 I did not forget about this, I'm a little caught up in a few other priorities right now but rest assured this is on my radar and I will get to this as soon as I can.
Thank you for your patience!

@KennyHuRadar KennyHuRadar mentioned this pull request Mar 5, 2025
@KennyHuRadar
Copy link
Contributor

Closing as https://github.com/radarlabs/flutter-radar/pull/82/files is merged into main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Does not build for Android with Flutter 3.29.0

3 participants