R2_590 change ESIL pop signature #21887
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
comments on this @condret ? |
|
Can you rebase this PR we should target r2-6.x now |
|
sorry for the late response. i'm not a fan of this. I don't see any necessity, and all these casts to char * feel bloaty to me. We can do this, if you really want this |
|
Theres a noticeable perf boost by not strduping every word. Thats the reason behind this patch. So maybe the casts are ugly but i wanted to make clear the intentions behind |
|
can't we then just rm the strdups |
|
Nope i tried. Some because invalid pointers. So we need again an abstraction over strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merge #21886 first, also this doesn't fix all warnings yet..