Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disassembly and analysis for or1k #15515

Merged
merged 19 commits into from
Nov 29, 2019
Merged

Disassembly and analysis for or1k #15515

merged 19 commits into from
Nov 29, 2019

Conversation

v3l0c1r4pt0r
Copy link
Contributor

@v3l0c1r4pt0r v3l0c1r4pt0r commented Nov 27, 2019

asm and anal plugins for OpenRISC 1000 architecture. This should fulfill issue #7118

tests at radareorg/radare2-regressions#2027

Try to stay within 78 column limit
Instead of defining instance of anonymous structure, declare the
structure with file scope
Analysis module could not find general or1k header
On gcc-5 should now work. const global variables cannot be used in
structure initialization. Fall back to defines
@lgtm-com
Copy link

lgtm-com bot commented Nov 27, 2019

This pull request introduces 7 alerts when merging 8ddb871 into f019584 - view on LGTM.com

new alerts:

  • 5 for FIXME comment
  • 1 for Empty branch of conditional
  • 1 for Short global name

MSVC complains about '{}' syntax. Adding zero inside the brackets should
fix the problem
Replace spaces with tabs
Immedaite value in this type of instruction is shifted left by 13. This
should fix regression tests
@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2019

This pull request introduces 7 alerts when merging 7cbbda9 into 69b97b0 - view on LGTM.com

new alerts:

  • 5 for FIXME comment
  • 1 for Empty branch of conditional
  • 1 for Short global name

@lgtm-com
Copy link

lgtm-com bot commented Nov 28, 2019

This pull request introduces 5 alerts when merging 3c06afd into 511e837 - view on LGTM.com

new alerts:

  • 5 for FIXME comment

@github-actions github-actions bot added the RAnal label Nov 28, 2019
@XVilka XVilka added this to the 4.1.0 milestone Nov 29, 2019
@XVilka XVilka requested a review from radare November 29, 2019 04:29
@radare radare merged commit e132818 into radareorg:master Nov 29, 2019
@radare
Copy link
Collaborator

radare commented Nov 29, 2019

awesome! thanks

@v3l0c1r4pt0r
Copy link
Contributor Author

You're welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants