Docs scroll fix #830
Docs scroll fix #830
Conversation
|
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 eslint
docs/app/docs/layout.tsxOops! Something went wrong! :( ESLint: 8.56.0 ESLint couldn't find the config "next/core-web-vitals" to extend from. Please check that the name of the config is correct. The config "next/core-web-vitals" was referenced from the config file in "/docs/.eslintrc.json". If you still have problems, please stop by https://eslint.org/chat/help to chat with the team. WalkthroughThe pull request introduces layout and styling modifications across multiple files in the documentation application. The changes primarily focus on adjusting the height, overflow, and responsiveness of various components. Key modifications include updating the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
docs/app/docs/layout.tsx (1)
Line range hint
15-15: Consider removing nested overflow-y-scroll.Having both
overflow-y-autoon the parent andoverflow-y-scrollon#docs-contentcould lead to nested scrollbars. Consider removing the scroll from#docs-contentand letting the parent handle scrolling.-<div className='lg:px-4 text-gray-1000 flex-1 flex flex-col gap-4 overflow-y-scroll pt-2' id="docs-content"> +<div className='lg:px-4 text-gray-1000 flex-1 flex flex-col gap-4 pt-2' id="docs-content">docs/components/navigation/Navigation.js (1)
250-250: LGTM! Proper height constraint with max-h-screen.Adding
max-h-screenensures the navigation stays within viewport bounds while maintaining its own scroll area.Consider removing arbitrary bottom padding.
The
pb-[200px]seems like a workaround. Consider using a more maintainable approach to ensure content is visible when scrolled.-<div className=' relative border-box px-1 overflow-y-auto overflow-x-hidden lg:block flex flex-col pb-[200px] min-w-[40px] min-h-[40px] max-h-screen'> +<div className=' relative border-box px-1 overflow-y-auto overflow-x-hidden lg:block flex flex-col min-w-[40px] min-h-[40px] max-h-screen'> + <div className="flex-1"> {/* existing content */} + </div> + <div className="h-8"> + {/* Add spacing component if needed */} + </div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
docs/app/docs/layout.tsx(1 hunks)docs/app/layout.js(1 hunks)docs/components/Main/Main.js(1 hunks)docs/components/navigation/Navigation.js(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build
🔇 Additional comments (4)
docs/components/Main/Main.js (2)
22-24: LGTM! Good use of flex-shrink-0.The addition of
flex-shrink-0prevents the navbar from collapsing when content grows, maintaining a consistent header size.
26-28: LGTM! Proper flex and overflow handling.The combination of
flex-1andoverflow-hiddenallows content to grow while preventing layout issues.docs/app/layout.js (1)
26-26: LGTM! Solid root layout structure.The addition of
h-screen flex flex-col overflow-hiddento the body element establishes a proper foundation for the nested layout components.docs/app/docs/layout.tsx (1)
11-11: LGTM! Better height handling with max-h-screen.Replacing fixed height with
max-h-screenimproves adaptability to different viewport sizes.
kotAPI
added
the
automerge
2 participants
css magic
Summary by CodeRabbit