Skip to content

Migrated AspectRatio Story to TS #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Migrated AspectRatio Story to TS #820

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...spectRatio/stories/AspectRatio.stories.js → ...pectRatio/stories/AspectRatio.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import AspectRatio from '../AspectRatio';
import React from 'react';
import AspectRatio, { AspectRatioProps } from '../AspectRatio';

Check warning on line 2 in src/components/ui/AspectRatio/stories/AspectRatio.stories.tsx

View workflow job for this annotation

GitHub Actions / lint 

'AspectRatioProps' is defined but never used
import SandboxEditor from '~/components/tools/SandboxEditor/SandboxEditor';

// More on how to set up stories at: https://storybook.js.org/docs/react/writing-stories/introduction#default-export
export default {
title: 'Components/AspectRatio',
component: AspectRatio,
render: (args) => <SandboxEditor>
render: (args: AspectRatioProps) => <SandboxEditor>
Copy link
Collaborator

@kotAPI kotAPI Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder how we can fix this 'AspectRatioProps' is defined but never used any leads?

Copy link
Contributor Author

@StDensity StDensity Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://discord.com/channels/1189498293441536120/1189528096769069128/1332321190638784593

SmartSelect_20250124_195644_Discord.jpg

Will this fix? #805

<AspectRatio {...args} >
<img
style={{ width: '100%', height: '100%', objectFit: 'cover' }}
Expand Down
Loading