Skip to content

Fix: add lin commit hook for css #765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jan 14, 2025
Merged

Fix: add lin commit hook for css #765

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
434059b
Fix: add lin commit hook for css
jalilseif10 Jan 11, 2025
3fb88a9
Fix: remove pre-commit list and add husky lint
jalilseif10 Jan 11, 2025
2467b46
Fix: remove the duplicate check stylelint
jalilseif10 Jan 11, 2025
0fa4fa8
Fix: add tailwindcss for stylelint
jalilseif10 Jan 11, 2025
2c91c28
Fix: remove redundant for stylelint
jalilseif10 Jan 11, 2025
9bcb3eb
Fix: remove redundant scss for stylelint
jalilseif10 Jan 11, 2025
39126b7
Merge branch 'main' into js199069/fix-issue-471
js199069 Jan 12, 2025
9929313
Fix: add updated package-lock
jalilseif10 Jan 12, 2025
58f740e
Merge branch 'main' into js199069/fix-issue-471
kodiakhq[bot] Jan 13, 2025
a6e9ec9
Merge branch 'main' into js199069/fix-issue-471
kodiakhq[bot] Jan 13, 2025
bd87eb9
Merge branch 'main' into js199069/fix-issue-471
kodiakhq[bot] Jan 13, 2025
5c91378
Merge branch 'main' into js199069/fix-issue-471
kodiakhq[bot] Jan 13, 2025
8877b79
Merge branch 'main' into js199069/fix-issue-471
kodiakhq[bot] Jan 13, 2025
d33c17b
ignore lint errors
jalilseif10 Jan 13, 2025
ebeb3ab
Merge branch 'js199069/fix-issue-471' of github.com:js199069/ui into …
jalilseif10 Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"extends": [
"stylelint-config-standard",
"stylelint-config-standard-scss",
"stylelint-config-tailwindcss"
],
"defaultSeverity": "warning",
Copy link
Contributor

@coderabbitai coderabbitai bot Jan 13, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Consider using "error" severity for pre-commit hooks.

Setting defaultSeverity to "warning" might be too lenient for a pre-commit hook, as it will allow commits even when style issues are detected. Consider changing it to "error" to ensure style consistency is enforced.

-  "defaultSeverity": "warning",
+  "defaultSeverity": "error",
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"defaultSeverity": "warning",
"defaultSeverity": "error",

Copy link
Contributor Author

@js199069 js199069 Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line assume errors as warnings
"defaultSeverity": "warning",

Copy link
Contributor

@coderabbitai coderabbitai bot Jan 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@js199069 I understand your approach. Setting the severity to "warning" is indeed a good strategy during the initial adoption phase, allowing the team to gradually address the style issues while maintaining development velocity.

⟪ ◕ᴗ◕ ⟫
∫∫∫

✏️ Learnings added 
Learnt from: js199069
PR: rad-ui/ui#765
File: .stylelintrc.json:7-7
Timestamp: 2025-01-13T18:10:34.853Z
Learning: In Stylelint configuration, setting `defaultSeverity` to "warning" is preferred during the initial setup phase to allow gradual adoption of style rules, especially when there are existing style issues to be addressed over time.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

"rules": {
"no-descending-specificity": null,
"scss/at-rule-no-unknown": null
}
}
Loading
Loading