Fix issue #687

[StDensity]

#687

Summary by CodeRabbit

• Refactor
  • Updated column identification in the Table component from using key to id
  • Updated column and data object properties in Table stories to use id instead of key
  • Adjusted test cases to reference id instead of key for validating table headers

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request modifies the Table component and its corresponding stories file by changing the property used to identify columns from key to id. This change is consistent across the component implementation in Table.tsx, the story definitions in Table.stories.js, and the test cases in Table.test.tsx. The modification appears to standardize column identification across the table-related files, maintaining existing functionality while updating the property naming convention.

Changes

File	Change Summary
src/components/ui/Table/Table.tsx	Replaced column.key with column.id in column mapping and header rendering
src/components/ui/Table/stories/Table.stories.js	Updated column and data objects to use id instead of key
src/components/ui/Table/tests/Table.test.tsx	Changed employeeKey array objects from { key: '...' } to { id: '...' }

Possibly related PRs

• Fix #735: Add tests for Table Component #736: The changes in this PR involve modifications to the Table.test.tsx file, specifically updating the property from key to id, which directly relates to the changes made in the main PR regarding the Table component's column identification.

Suggested reviewers

• kotAPI

Poem

🐰 Hop, hop, through the table's domain,
Where keys transform and columns reign,
From key to id, a subtle dance,
A rabbit's code with elegant stance!
Refactoring magic, clean and bright! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ace79ee and d445569.

📒 Files selected for processing (1)

• src/components/ui/Table/tests/Table.test.tsx (1 hunks)

Finishing Touches

• 📝 Generate Docstrings

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 3

🔭 Outside diff range comments (2)

src/components/ui/Table/Table.tsx (2)

Line range hint 33-37: Fix key generation in table cells

The current implementation can lead to duplicate keys when column IDs are empty strings.

                            columnMap.map((column:any) => {
-                                return <TableCell key={`${row.id}-${column}`}>
+                                return <TableCell key={`${row.id}-${column || Math.random()}`}>
                                    {row[column] || ''}
                                </TableCell>;
                            })

However, a better solution would be to prevent this situation entirely by ensuring column IDs are always present, as suggested in the previous comments.

🧰 Tools

🪛 GitHub Actions: Build RAD UI

[warning] 11-11: Duplicate keys detected in table rows. Keys should be unique to maintain component identity across updates. Multiple rows found with keys: '', '1-', '2-', '3-', '4-'.

---

Test data structure needs to be updated to use 'id' instead of 'key' property

The test file is out of sync with the component implementation:

• src/components/ui/Table/tests/Table.test.tsx: Update the employeeKey array to use id instead of key property:

const employeeKey = [
    { key: 'id', name: 'Employee Id' },    // Should be { id: 'id', name: 'Employee Id' }
    { key: 'fullName', name: 'Full Name' }, // Should be { id: 'fullName', name: 'Full Name' }
    ...
];

🔗 Analysis chain

Line range hint 1-50: Verify the impact of switching from 'key' to 'id' across the codebase

Let's ensure there are no remaining references to the old 'key' property in other components or tests.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining references to column.key in the codebase
rg -l "column.key" src/
# Search for any table-related test files that might need updates
fd "Table.*test" src/

Length of output: 92

---

Script:

#!/bin/bash
# Check content of the test file
cat src/components/ui/Table/tests/Table.test.tsx

# Search for potential variations of key property access
rg -i "column.*key|key.*column" src/

# Search for table column property access patterns
ast-grep --pattern 'column.$_'

Length of output: 2750

🧰 Tools

🪛 GitHub Actions: Build RAD UI

[warning] 11-11: Duplicate keys detected in table rows. Keys should be unique to maintain component identity across updates. Multiple rows found with keys: '', '1-', '2-', '3-', '4-'.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 15ecc8c and ace79ee.

📒 Files selected for processing (2)

• src/components/ui/Table/Table.tsx (2 hunks)
• src/components/ui/Table/stories/Table.stories.js (1 hunks)

🧰 Additional context used

🪛 GitHub Actions: Build RAD UI

src/components/ui/Table/Table.tsx

[warning] 11-11: Duplicate keys detected in table rows. Keys should be unique to maintain component identity across updates. Multiple rows found with keys: '', '1-', '2-', '3-', '4-'.

🔇 Additional comments (1)

src/components/ui/Table/stories/Table.stories.js (1)

13-14: LGTM! Column and data definitions properly updated

The changes correctly implement the switch from key to id property, maintaining consistency with the Table component changes. The test data includes proper unique IDs for each row.

Also applies to: 18-21