-
-
Notifications
You must be signed in to change notification settings - Fork 53
Fix #735: Add tests for Table Component #736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import React from 'react'; | ||
| import { render, RenderResult } from '@testing-library/react'; | ||
|
|
||
| import Table from '../Table'; | ||
|
|
||
| describe('Table Component', () => { | ||
| const employeeData = [ | ||
| { id: 1, fullName: 'John Smith', age: 23, isIntern: 'No' }, | ||
| { id: 2, fullName: 'Anna Donie', age: 35, isIntern: 'Yes' }, | ||
| { id: 3, fullName: 'Hannah Brown', age: 20, isIntern: 'Yes' }, | ||
| { id: 4, fullName: 'Johnathan White Jr', age: 36, isIntern: 'No' }, | ||
| ]; | ||
|
|
||
| const employeeKey = [ | ||
| { key: 'id', name: 'Employee Id' }, | ||
| { key: 'fullName', name: 'Full Name' }, | ||
| { key: 'age', name: 'Age' }, | ||
| { key: 'isIntern', name: 'In Internship' }, | ||
| ]; | ||
|
|
||
| let result: RenderResult; | ||
| let container: HTMLElement; | ||
|
|
||
| beforeEach(() => { | ||
| result = render( | ||
| <Table columns={employeeKey} data={employeeData}></Table> | ||
| ); | ||
| container = result.container; | ||
| }); | ||
|
Comment on lines
+24
to
+29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion Add test cleanup While the test setup is good, it's missing cleanup after each test to prevent potential test interference. Add this after the beforeEach block: afterEach(() => {
result.unmount();
}); |
||
|
|
||
| it('renders without crashing', () => { | ||
| const tableElements = container.querySelectorAll('table'); | ||
| expect(tableElements.length).toEqual(1); | ||
| expect(tableElements[0]).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('renders correct user defined headers', () => { | ||
| const headerRows = container.querySelectorAll('table thead tr'); | ||
| expect(headerRows.length).toEqual(1); | ||
|
|
||
| const headers = headerRows[0].querySelectorAll('th'); | ||
| expect(headers.length).toEqual(4); | ||
|
|
||
| headers.forEach((header, index) => { | ||
| expect(header.textContent).toEqual(employeeKey[index].name); | ||
| }); | ||
| }); | ||
|
|
||
| it('renders correct user defined data', () => { | ||
| const tbodyElements = container.querySelectorAll('tbody'); | ||
| expect(tbodyElements.length).toEqual(1); | ||
|
|
||
| const dataRows = tbodyElements[0].querySelectorAll('tr'); | ||
| expect(dataRows.length).toEqual(4); | ||
|
|
||
| dataRows.forEach((row, rowIndex) => { | ||
| const dataCells = row.querySelectorAll('td'); | ||
| expect(dataCells.length).toEqual(4); | ||
|
|
||
| dataCells.forEach((cell, cellIndex) => { | ||
| expect(cell.textContent).toEqual( | ||
| Object.values(employeeData[rowIndex])[cellIndex].toString() | ||
| ); | ||
| }); | ||
| }); | ||
| }); | ||
| }); | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix trailing comma style issues
The trailing commas in the arrays are causing linting errors.
Apply this fix:
const employeeKey = [ { key: 'id', name: 'Employee Id' }, { key: 'fullName', name: 'Full Name' }, { key: 'age', name: 'Age' }, - { key: 'isIntern', name: 'In Internship' }, + { key: 'isIntern', name: 'In Internship' } ];📝 Committable suggestion
🧰 Tools
🪛 eslint
[error] 18-18: Unexpected trailing comma.
(comma-dangle)