Skip to content

CI Step to run build scripts #561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2024
Merged

CI Step to run build scripts #561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
51af251
Update @radui/ui version to 0.0.25 in package files
kotAPI Nov 16, 2024
59265bc
Merge remote-tracking branch 'origin/main'
kotAPI Nov 16, 2024
ed73a98
Add jsx-a11y rules and workflow for building RAD UI
kotAPI Nov 16, 2024
fdb9061
Update ESLint rules for accessibility warnings
kotAPI Nov 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 35 additions & 5 deletions .eslintrc.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = {
'plugin:react/recommended',
'eslint:recommended',
'standard',
'plugin:jsx-a11y/recommended',
'plugin:jsx-a11y/recommended'
],
overrides: [
],
Expand All @@ -19,11 +19,9 @@ module.exports = {
},
plugins: [
'react',
'jsx-a11y',
'jsx-a11y'
],
rules: {
'jsx-a11y/alt-text': 'warn',
'jsx-a11y/anchor-is-valid': 'warn',
'react/react-in-jsx-scope': 'off',
indent: ['warn', 4],
'key-spacing': ['warn', { beforeColon: false, afterColon: true }],
Expand Down Expand Up @@ -64,6 +62,38 @@ module.exports = {
semi: [
'warn',
'always'
]
],
'jsx-a11y/alt-text': 'warn',
'jsx-a11y/anchor-is-valid': 'warn',
'jsx-a11y/accessible-emoji': 'warn',
'jsx-a11y/anchor-has-content': 'warn',
'jsx-a11y/aria-activedescendant-has-tabindex': 'warn',
'jsx-a11y/aria-props': 'warn',
'jsx-a11y/aria-proptypes': 'warn',
'jsx-a11y/aria-role': 'warn',
'jsx-a11y/aria-unsupported-elements': 'warn',
'jsx-a11y/click-events-have-key-events': 'warn',
'jsx-a11y/heading-has-content': 'warn',
'jsx-a11y/html-has-lang': 'warn',
'jsx-a11y/iframe-has-title': 'warn',
'jsx-a11y/img-redundant-alt': 'warn',
'jsx-a11y/interactive-supports-focus': 'warn',
'jsx-a11y/label-has-associated-control': 'warn',
'jsx-a11y/media-has-caption': 'warn',
'jsx-a11y/mouse-events-have-key-events': 'warn',
'jsx-a11y/no-access-key': 'warn',
'jsx-a11y/no-autofocus': 'warn',
'jsx-a11y/no-distracting-elements': 'warn',
'jsx-a11y/no-interactive-element-to-noninteractive-role': 'warn',
'jsx-a11y/no-noninteractive-element-interactions': 'warn',
'jsx-a11y/no-noninteractive-element-to-interactive-role': 'warn',
'jsx-a11y/no-noninteractive-tabindex': 'warn',
'jsx-a11y/no-onchange': 'warn',
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Remove deprecated 'no-onchange' rule

The 'jsx-a11y/no-onchange' rule is deprecated as onChange events are now well-supported by all browsers and screen readers.

-        'jsx-a11y/no-onchange': 'warn',
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
'jsx-a11y/no-onchange': 'warn',

'jsx-a11y/no-redundant-roles': 'warn',
'jsx-a11y/no-static-element-interactions': 'warn',
'jsx-a11y/role-has-required-aria-props': 'warn',
'jsx-a11y/role-supports-aria-props': 'warn',
'jsx-a11y/scope': 'warn',
'jsx-a11y/tabindex-no-positive': 'warn'
Comment on lines +68 to +97
Copy link
Contributor

@coderabbitai coderabbitai bot Nov 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🛠️ Refactor suggestion

Review accessibility rule severity levels

While it's good to start with 'warn' level during initial implementation, consider:

  1. Upgrading critical accessibility rules to 'error' level, such as:
    • aria-props
    • aria-role
    • role-has-required-aria-props
    • alt-text
  2. This ensures critical accessibility issues don't make it to production.

}
};
24 changes: 24 additions & 0 deletions .github/workflows/build-rad-ui.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
name: Build RAD UI

on:
pull_request:
branches: [ main ]

jobs:
build:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: '20'
cache: 'npm'

- name: Install dependencies
run: npm ci

- name: Build
run: npm run build
12 changes: 6 additions & 6 deletions docs/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"update-rad": "npm update @radui/ui"
},
"dependencies": {
"@radui/ui": "^0.0.23",
"@radui/ui": "^0.0.25",
"@types/node": "20.5.9",
"@types/react": "18.2.21",
"@types/react-dom": "18.2.7",
Expand Down
Loading