-
-
Notifications
You must be signed in to change notification settings - Fork 53
ci: run lint and tests only on pull requests #1575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: run lint and tests only on pull requests #1575
Conversation
|
WalkthroughThe lint and test GitHub Actions workflows were updated to remove push event triggers. Both workflows now trigger only on pull_request events (lint: to main; test: to main and security-fixes). All other workflow configuration remains unchanged. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Dev as Developer
participant GH as GitHub
participant Lint as Lint Workflow
participant Test as Test Workflow
Note over GH,Lint: New behavior (push no longer triggers)
Dev->>GH: Open/Update PR targeting main/security-fixes
GH-->>Lint: Trigger on pull_request (lint.yml targets main)
GH-->>Test: Trigger on pull_request (test.yml targets main, security-fixes)
par Workflows run
Lint->>Lint: Setup Node, npm ci, lint
Test->>Test: Setup, build/test steps
end
alt Push to main
Dev->>GH: Push commit to main
GH--X Lint: No trigger (push removed)
GH--X Test: No trigger (push removed)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Comment |
CoverageThis report compares the PR with the base branch. “Δ” shows how the PR affects each metric.
Coverage improved or stayed the same. Great job! Run |
Summary by CodeRabbit