Skip to content

Conversation

@kotAPI
Copy link
Collaborator

@kotAPI kotAPI commented Sep 14, 2025

Summary by CodeRabbit

  • Chores
    • Updated CI configuration to run linting and tests only on pull requests, reducing redundant runs on direct pushes.
    • Pull request validation remains active for targeted branches, ensuring consistent quality checks while streamlining pipelines.
    • No changes to application functionality or user-facing behavior.

@changeset-bot
Copy link

changeset-bot bot commented Sep 14, 2025

⚠️ No Changeset found

Latest commit: 556befe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 14, 2025

Walkthrough

The lint and test GitHub Actions workflows were updated to remove push event triggers. Both workflows now trigger only on pull_request events (lint: to main; test: to main and security-fixes). All other workflow configuration remains unchanged.

Changes

Cohort / File(s) Summary of Changes
Workflow triggers: pull_request-only
\.github/workflows/lint.yml, \.github/workflows/test.yml
Removed push: triggers. Preserved existing pull_request triggers (lint: main; test: main, security-fixes) and path filters. No other steps or settings changed.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Dev as Developer
  participant GH as GitHub
  participant Lint as Lint Workflow
  participant Test as Test Workflow

  Note over GH,Lint: New behavior (push no longer triggers)
  Dev->>GH: Open/Update PR targeting main/security-fixes
  GH-->>Lint: Trigger on pull_request (lint.yml targets main)
  GH-->>Test: Trigger on pull_request (test.yml targets main, security-fixes)
  par Workflows run
    Lint->>Lint: Setup Node, npm ci, lint
    Test->>Test: Setup, build/test steps
  end
  alt Push to main
    Dev->>GH: Push commit to main
    GH--X Lint: No trigger (push removed)
    GH--X Test: No trigger (push removed)
  end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

I hop through YAML fields so bright,
Snipping pushes from the night—
Only PR moons now light the sky,
Lint and tests on branches fly.
Thump-thump! My paws approve the run,
Fewer wakes on every push—bun fun. 🐇✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "ci: run lint and tests only on pull requests" succinctly and accurately describes the primary change in the patchset—removing push triggers so lint and test workflows run only on pull_request events—and is concise and clear for reviewers scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch kotapi/locate-actions-that-don-t-run-after-pr-merge

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cb1205d and 556befe.

📒 Files selected for processing (2)
  • .github/workflows/lint.yml (0 hunks)
  • .github/workflows/test.yml (0 hunks)
💤 Files with no reviewable changes (2)
  • .github/workflows/lint.yml
  • .github/workflows/test.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Build
  • GitHub Check: coverage

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Coverage

This report compares the PR with the base branch. “Δ” shows how the PR affects each metric.

Metric PR Δ
Statements 88.42% +0.00%
Branches 63.37% +0.00%
Functions 72.98% +0.00%
Lines 87.32% +0.00%

Coverage improved or stayed the same. Great job!

Run npm run coverage locally for detailed reports and target untested areas to raise these numbers.

@kotAPI kotAPI merged commit 8ba8ef9 into main Sep 14, 2025
11 checks passed
@kotAPI kotAPI deleted the kotapi/locate-actions-that-don-t-run-after-pr-merge branch September 14, 2025 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants