-
-
Notifications
You must be signed in to change notification settings - Fork 53
test: capture radio warning #1551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughAdds a console.warn spy and assertion to the RadioPrimitive asChild test in src/core/primitives/Radio/tests/Radio.test.tsx, verifying a specific warning message is logged when using asChild. Restores the mock after assertion and still checks the radio element renders in the document. Changes
Sequence Diagram(s)Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Pre-merge checks (3 passed)✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
CoverageThis report compares the PR with the base branch. “Δ” shows how the PR affects each metric.
Coverage improved or stayed the same. Great job! Run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/core/primitives/Radio/tests/Radio.test.tsx (2)
44-52: Make the warning assertion more robust and guarantee cleanup.
- Match by substring to avoid brittleness if the message wording changes.
- Assert it fires exactly once.
- Use try/finally so the mock is restored even if an assertion fails.
- const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {}); - render(<RadioPrimitive {...baseProps} asChild />); - const radio = screen.getByRole('radio'); - expect(radio).toBeInTheDocument(); - expect(warnSpy).toHaveBeenCalledWith( - 'Primitive.input: asChild prop requires exactly one valid child element.' - ); - warnSpy.mockRestore(); + const warnSpy = jest.spyOn(console, 'warn').mockImplementation(() => {}); + try { + render(<RadioPrimitive {...baseProps} asChild />); + const radio = screen.getByRole('radio'); + expect(radio).toBeInTheDocument(); + expect(warnSpy).toHaveBeenCalledWith( + expect.stringContaining('asChild prop requires exactly one valid child') + ); + expect(warnSpy).toHaveBeenCalledTimes(1); + } finally { + warnSpy.mockRestore(); + }
43-43: Rename test to reflect its behavior.Clarify that it asserts a warning as well as rendering.
-it('supports asChild prop (renders without error)', () => { +it('supports asChild prop: warns when missing child and still renders input', () => {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/core/primitives/Radio/tests/Radio.test.tsx(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: coverage
Summary
Primitive.inputwarning whenasChildhas no childTesting
npm test src/core/primitives/Radio/tests/Radio.test.tsxSummary by CodeRabbit