Skip to content

Conversation

@GoldGroove06
Copy link
Contributor

@GoldGroove06 GoldGroove06 commented Jul 11, 2025

Summary by CodeRabbit

  • New Features

    • Introduced a customizable Radio component with support for different sizes, colors, and variants.
    • Added a new radio group component with improved accessibility, keyboard navigation, and bidirectional text support.
    • Added Storybook stories for Radio and Radio Group components to showcase usage and variants.
  • Bug Fixes

    • Improved type safety and context usage for radio group components.
    • Enhanced accessibility attributes for radio and radio group elements.
  • Style

    • Added and updated SCSS styles for radio and radio group components for improved appearance and theming.
  • Tests

    • Added comprehensive tests for Radio, RadioPrimitive, and RadioGroupPrimitive components to ensure correct rendering, interaction, and accessibility.
  • Refactor

    • Refined internal component structures for better controlled/uncontrolled state handling and focus management.
    • Updated keyboard navigation logic to support both horizontal and vertical orientations, as well as right-to-left layouts.
  • Chores

    • Reformatted and cleaned up code and style files for consistency and maintainability.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 11, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This update introduces a new high-level Radio React component with extended props, internal checked state, and custom styling, along with associated Storybook stories and test suites. It refactors the lower-level RadioPrimitive and RadioGroupPrimitive components, improves type safety and accessibility, adds roving focus and bidirectional support, and updates or adds relevant stylesheets and documentation.

Changes

File(s) Change Summary
src/components/ui/Radio/Radio.tsx, stories/Radio.stories.tsx, tests/Radio.test.tsx Added new Radio component, Storybook stories, and test suite covering props, variants, and state handling.
src/core/primitives/Radio/index.tsx, stories/RadioPrimitive.stories.tsx, tests/Radio.test.tsx Refactored RadioPrimitive to be stateless and prop-driven, updated stories to prop-driven format, added new tests for rendering and props.
src/core/primitives/RadioGroup/RadioGroupPrimitive.stories.tsx, .../tests/RadioGroupPrimtive.test.tsx Replaced JS stories with TSX, added new stories and tests for controlled/uncontrolled state, accessibility, and error handling.
src/core/primitives/RadioGroup/context/RadioGroupContext.tsx Refactored context to use a strongly typed interface and null default, improving type safety.
src/core/primitives/RadioGroup/fragments/RadioGroupPrimitiveItem.tsx, .../RadioGroupPrimitiveRoot.tsx Refactored item/root components for controlled/uncontrolled support, accessibility, and roving focus integration.
src/core/primitives/RadioGroup/RadioGroupPrimitive.tsx Changed export from plain object to functional component warning against direct use.
src/core/primitives/Primitive/index.tsx Updated PrimitiveProps to a union type for better element-specific typing.
src/core/utils/RovingFocusGroup/context/RovingFocusRootContext.tsx, .../fragments/RovingFocusRoot.tsx, .../fragments/RovingFocusItem.tsx Extended context and components to support bidirectional text (dir), 'both' orientation, and improved keyboard navigation.
styles/themes/components/radio-group.scss, radio.scss, default.scss Added new radio group styles, removed group styles from radio.scss, and imported radio-group styles into the default theme.
styles/themes/components/blockquote.scss, checkbox.scss Minor whitespace formatting changes.
styles/jsTokens/colors.tokens.js Reformatted color token export object for style consistency.
src/components/ui/TabNav/fragments/TabNavLink.tsx, .../Dialog/fragments/DialogPrimitiveRoot.tsx, .../Select/fragments/SelectPrimitiveContent.tsx, .../Select/fragments/SelectPrimitiveItem.tsx Minor formatting and whitespace adjustments.
src/core/primitives/RadioGroup/RadioGroupPrimitive.stories.js Deleted obsolete JS story file for RadioGroupPrimitive.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Radio
  participant RadioPrimitive

  User->>Radio: Clicks radio button
  Radio->>Radio: Toggles internal checked state
  Radio->>RadioPrimitive: Passes checked, styling, and other props
  RadioPrimitive->>RadioPrimitive: Renders input with props
  Radio->>User: Calls onChange callback (if provided)
Loading
sequenceDiagram
  participant User
  participant RadioGroupPrimitiveRoot
  participant RadioGroupPrimitiveItem

  User->>RadioGroupPrimitiveItem: Clicks radio option
  RadioGroupPrimitiveItem->>RadioGroupPrimitiveRoot: setSelectedValue(value)
  RadioGroupPrimitiveRoot->>RadioGroupPrimitiveRoot: Updates selectedValue (controlled/uncontrolled)
  RadioGroupPrimitiveRoot->>RadioGroupPrimitiveItem: Context updates checked state
  RadioGroupPrimitiveRoot->>User: Calls onValueChange callback (if provided)
Loading

Possibly related issues

Possibly related PRs

Suggested reviewers

  • GoldGroove06

Poem

🐇
New radios hop into the scene,
With stories, tests, and styles so clean.
Roving focus, colors bright,
Groups and singles work just right.
Context strong and types anew—
A bunny’s job is never through!
🥕

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-07-11T08_58_29_074Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ecd616f and 115eabe.

📒 Files selected for processing (27)
  • src/components/ui/Radio/Radio.tsx (1 hunks)
  • src/components/ui/Radio/stories/Radio.stories.tsx (1 hunks)
  • src/components/ui/Radio/tests/Radio.test.tsx (1 hunks)
  • src/components/ui/TabNav/fragments/TabNavLink.tsx (0 hunks)
  • src/core/primitives/Dialog/fragments/DialogPrimitiveRoot.tsx (1 hunks)
  • src/core/primitives/Primitive/index.tsx (1 hunks)
  • src/core/primitives/Radio/RadioPrimitive.stories.tsx (2 hunks)
  • src/core/primitives/Radio/index.tsx (1 hunks)
  • src/core/primitives/Radio/tests/Radio.test.tsx (1 hunks)
  • src/core/primitives/RadioGroup/RadioGroupPrimitive.stories.js (0 hunks)
  • src/core/primitives/RadioGroup/RadioGroupPrimitive.stories.tsx (1 hunks)
  • src/core/primitives/RadioGroup/RadioGroupPrimitive.tsx (1 hunks)
  • src/core/primitives/RadioGroup/context/RadioGroupContext.tsx (1 hunks)
  • src/core/primitives/RadioGroup/fragments/RadioGroupPrimitiveItem.tsx (1 hunks)
  • src/core/primitives/RadioGroup/fragments/RadioGroupPrimitiveRoot.tsx (1 hunks)
  • src/core/primitives/RadioGroup/tests/RadioGroupPrimtive.test.tsx (1 hunks)
  • src/core/primitives/Select/fragments/SelectPrimitiveContent.tsx (1 hunks)
  • src/core/primitives/Select/fragments/SelectPrimitiveItem.tsx (1 hunks)
  • src/core/utils/RovingFocusGroup/context/RovingFocusRootContext.tsx (2 hunks)
  • src/core/utils/RovingFocusGroup/fragments/RovingFocusItem.tsx (2 hunks)
  • src/core/utils/RovingFocusGroup/fragments/RovingFocusRoot.tsx (2 hunks)
  • styles/jsTokens/colors.tokens.js (1 hunks)
  • styles/themes/components/blockquote.scss (1 hunks)
  • styles/themes/components/checkbox.scss (1 hunks)
  • styles/themes/components/radio-group.scss (1 hunks)
  • styles/themes/components/radio.scss (2 hunks)
  • styles/themes/default.scss (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kotAPI kotAPI added the automerge A tag that tells kodiak bot to automerge PRs for us when tests and approval conditions are met label Jul 11, 2025
@kodiakhq kodiakhq bot merged commit 63923c3 into main Jul 11, 2025
8 checks passed
@kodiakhq kodiakhq bot deleted the revert-changes branch July 11, 2025 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge A tag that tells kodiak bot to automerge PRs for us when tests and approval conditions are met

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants