CatalogService does not initialize region if regionless = true

[tmilos]

Regionless services, like DNS does not get initialized with region and fail on
Rackspace::dnsService
ServiceBuilder::factory
CatalogService::__construct
CatalogService::findEndpoint
CatalogItem::getEndpointFromRegion
line 139 with message
This service [cloudDNS] does not have access to the [] endpoint.

[coveralls]

Coverage remained the same when pulling cc2fce4 on tmilos:RegionLessCatalogService into b28780d on rackspace:master.

[jamiehannaford]

@tmilos For your PR, we always merge to the working branch - not master.

What version of PHP are you using? I'm using 5.5.11 and can't reproduce the error you're experiencing. All that happens on that line is that it assigns the $region as well as checking it's not NULL or FALSE. Moving the assignment operation to a new line doesn't change the way it works IMO.

[tmilos]

I'm on 5.4.19. I'm not sure how it can work at yours. It's documented on http://php.net/manual/en/language.operators.logical.php as short-circuit

// foo() will never get called as those operators are short-circuit
$a = (false && foo());

[tmilos]

I forgot to mention. I noticed this on v1.9.2. Haven't tried master, but looked at the code and it seems the same.

[jamiehannaford]

@tmilos Since the DNS service is regionless, the first operator should always fail - meaning that the $region assignment should never happen. What I'm struggling to understand is why do you need to set the $region property for the DNS service?

[gecampbell]

They launched a LON endpoint last week

Sent from my iPhone

On Apr 28, 2014, at 8:10 AM, "Jamie Hannaford" <notifications@github.commailto:notifications@github.com> wrote:

@tmiloshttps://github.com/tmilos Since the DNS service is regionless, the first operator should always fail - meaning that the $region assignment should never happen. What I'm struggling to understand is why do you need to set the $region property for the DNS service?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/344#issuecomment-41555751.

[jamiehannaford]

@tmilos Sorry for not realizing this. Although I tried authenticating against the LON region, it doesn't throw an exception if you provide US credentials. Only if you provide UK credentials. Thanks again for pointing this out.

[gecampbell]

Yes, it’s still a global service, but they’re providing other endpoints for, presumably, better performance.

On Apr 28, 2014, at 9:01 AM, Jamie Hannaford <notifications@github.commailto:notifications@github.com> wrote:

@tmiloshttps://github.com/tmilos Sorry for not realizing this. Although I tried authenticating against the LON region, it doesn't throw an exception if you provide US credentials. Only if you provide UK credentials. Thanks again for pointing this out.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/344#issuecomment-41561196.