Added existing entity support and configuration hash support #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/yum due to yum_key change, issue 49
recipes/entity.rb
Outdated
Contributor
There was a problem hiding this comment.
Monitoring is not regional. This is not supported in the fog backend or should it be used here.
…m libraries/cloud_monitoring
Contributor
There was a problem hiding this comment.
I'd have gone with something like next if value["ip_addresses"].nil? || node["cloud"].nil?, so that the next 3 lines aren't indented another level.
Contributor
|
this went silent for a while, but these changes seem reasonable. +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added recipes to reuse existing entities and to allow configuration via a configuration hash. No breaking changes made. Includes the yum version pin from pull request #51.