Automated Resyntax fixes #737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![resyntax-ci[bot]](https://avatars.githubusercontent.com/in/999945?s=60&v=4){kind=small}
This method chain made of nested `send` expressions can be written more clearly as a `send+` expression.
This expression can be replaced with a simpler, equivalent `hash-update!` expression.
Use the `#:unless` keyword instead of `unless` to reduce loop body indentation.
This `hash-for-each` operation can be replaced with a `for` loop.
`cond` with internal definitions is preferred over `if` with `let`, to reduce nesting
Internal definitions are recommended instead of `let` expressions, to reduce nesting.
This `sort` expression can be replaced with a simpler, equivalent expression.
The condition of this `if` expression is already a boolean and can be used directly.
|
I don't see any problems from reading the diff. |
jackfirth
reviewed
May 7, 2025
| (test:set-radio-box-item! "No debugging or profiling") | ||
| (let ([f (test:get-active-top-level-window)]) | ||
| (test:button-push "OK") | ||
| (wait-for-new-frame f))) |
There was a problem hiding this comment.
Resyntax missed an opportunity to inline this begin form. Fixing in jackfirth/resyntax#455.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resyntax fixed 20 issues in 4 files.
let-to-definesend-chain-to-send+if-let-to-condhash-set!-ref-to-hash-update!hash-for-each-to-forif-then-true-else-false-to-conditionunless-expression-in-for-loop-to-unless-keywordsort-with-keyed-comparator-to-sort-by-key