Skip to content

CIDM-1566 - Add via-header to container config #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

scarlettmoonbell
Copy link
Contributor

With the new behavior surrounding the via, via-header and repose-version options in container config. We found we were leaking the repose version. This updates the puppet module so we can control the via header and repose version in the user response.

@scarlettmoonbell scarlettmoonbell force-pushed the CIDM-1566-add-update-container-via-options branch from 0727242 to df75755 Compare December 17, 2018 19:31
Copy link

@adrianjgeorge adrianjgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes don't really reflect how this option changed. You can find more details here: http://www.openrepose.org/versions/8.10.0.0/architecture/container.html#via-header-configuration
Sadly, we have failed to provide an example there, but you can find one here: https://github.com/rackerlabs/repose/blob/master/repose-aggregator/tests/functional-tests/src/integrationTest/configs/features/core/via/element/container.cfg.xml
I'd probably also add a check to make sure that via and the new options aren't ever trying to be used simultaneously, because that will fail within repose.

@scarlettmoonbell scarlettmoonbell force-pushed the CIDM-1566-add-update-container-via-options branch from df75755 to c8f1013 Compare April 4, 2019 21:41
@scarlettmoonbell
Copy link
Contributor Author

@adrianjgeorge All of your comments should be addressed in this amended commit.

  • error thrown if both via and via-header are set
  • variable in depreciated section removed
  • via-header properly set as it's own element in container.cfg.xml

Copy link

@adrianjgeorge adrianjgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any deal breakers here.

@scarlettmoonbell scarlettmoonbell force-pushed the CIDM-1566-add-update-container-via-options branch from c8f1013 to b6d6c6e Compare April 16, 2019 16:19
@scarlettmoonbell
Copy link
Contributor Author

@adrianjgeorge The two issues you mentioned have been resolved in the amended commit. Thanks for the catches.

@scarlettmoonbell scarlettmoonbell changed the title CIDM-1566 - Add via-header and repose-version to container config CIDM-1566 - Add via-header to container config Apr 16, 2019
@adrianjgeorge
Copy link

Looks good to me.

@jstraw jstraw merged commit 2bec3d4 into rackerlabs:master Apr 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants