This repository has been archived by the owner on Jul 28, 2021. It is now read-only.
Add handling for AuthFailure exceptions when describing instances or snapshots #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcmtb
approved these changes
Apr 25, 2019
stevengorrell
approved these changes
Apr 25, 2019
martinb3
approved these changes
Apr 25, 2019
There was a problem hiding this comment.
LGTM. Should we be concerend that Rackers may configure backups against an unsupported region? Perhaps there's some kind of validation we could do when they push a config, like calling the existing sanity check logic? That would at least point out that they've configured backups but no EC2 instances matched.
|
That's a good call out. Let me push that out to a new issue to track, and we can look into adding the sanity checks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #70
An unexpected region was being returned by the
describe_regionscall. Attempts to calldescribe_instancesfrom this new endpoint were throwing aAuthFailureClient Error. This change updates the existing error handling to explicitly catch ClientErrors, and if the previously handled error (OptInRequired) or the new error (AuthFailure) are encountered, we will assume no instances\snapshots in the region.