Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unintended effects on load_config_initializers and other gems load order #457

Merged
merged 1 commit into from
Oct 30, 2019
Merged

fix: avoid unintended effects on load_config_initializers and other gems load order #457

merged 1 commit into from
Oct 30, 2019

Commits on Oct 29, 2019

  1. fix: avoid unintended effects on load_config_initializers and other g… 

    …ems load order

Because of the sort algorithm rails uses to satisfy `after` and `before`
constraints, gems can have unintended effects on others. See
rails/rails@0a120a8

Prefer making rack-attack middleware idempotent instead of relying on
the load order and the contents of the middleware stack too much.

closes #452
closes #456
    @grzuy
    grzuy committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    e3056e7 View commit details
    Browse the repository at this point in the history