Remove shape-directed import pattern parsing (nushell#7570)

crates/nu-cli/src/completions/custom_completions.rs

@@ -66,6 +66,7 @@ impl Completer for CustomCompletion {
                 ],
                 redirect_stdout: true,
                 redirect_stderr: true,
+                parser_info: vec![],
             },
             PipelineData::empty(),
         );

crates/nu-command/src/core_commands/export_use.rs

@@ -17,7 +17,12 @@ impl Command for ExportUse {
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build("export use")
             .input_output_types(vec![(Type::Nothing, Type::Nothing)])
-            .required("pattern", SyntaxShape::ImportPattern, "import pattern")
+            .required("module", SyntaxShape::String, "Module or module file")
+            .optional(
+                "members",
+                SyntaxShape::Any,
+                "Which members of the module to import",
+            )
             .category(Category::Core)
     }
 

crates/nu-command/src/core_commands/hide.rs

@@ -15,7 +15,12 @@ impl Command for Hide {
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build("hide")
             .input_output_types(vec![(Type::Nothing, Type::Nothing)])
-            .required("pattern", SyntaxShape::ImportPattern, "import pattern")
+            .required("module", SyntaxShape::String, "Module or module file")
+            .optional(
+                "members",
+                SyntaxShape::Any,
+                "Which members of the module to import",
+            )
             .category(Category::Core)
     }
 
@@ -44,7 +49,7 @@ This command is a parser keyword. For details, check:
         let env_var_name = if let Some(Expression {
             expr: Expr::ImportPattern(pat),
             ..
-        }) = call.positional_nth(0)
+        }) = call.parser_info_nth(0)
         {
             Spanned {
                 item: String::from_utf8_lossy(&pat.head.name).to_string(),

crates/nu-command/src/core_commands/overlay/use_.rs

@@ -66,7 +66,7 @@ impl Command for OverlayUse {
         let mut name_arg: Spanned<String> = call.req(engine_state, caller_stack, 0)?;
         name_arg.item = trim_quotes_str(&name_arg.item).to_string();
 
-        let maybe_origin_module_id = if let Some(overlay_expr) = call.positional_nth(0) {
+        let maybe_origin_module_id = if let Some(overlay_expr) = call.parser_info_nth(0) {
             if let Expr::Overlay(module_id) = overlay_expr.expr {
                 module_id
             } else {

crates/nu-command/src/core_commands/use_.rs

@@ -20,7 +20,12 @@ impl Command for Use {
     fn signature(&self) -> nu_protocol::Signature {
         Signature::build("use")
             .input_output_types(vec![(Type::Nothing, Type::Nothing)])
-            .required("pattern", SyntaxShape::ImportPattern, "import pattern")
+            .required("module", SyntaxShape::String, "Module or module file")
+            .optional(
+                "members",
+                SyntaxShape::Any,
+                "Which members of the module to import",
+            )
             .category(Category::Core)
     }
 
@@ -43,7 +48,7 @@ impl Command for Use {
         let import_pattern = if let Some(Expression {
             expr: Expr::ImportPattern(pat),
             ..
-        }) = call.positional_nth(0)
+        }) = call.parser_info_nth(0)
         {
             pat
         } else {

crates/nu-command/src/deprecated/source.rs

@@ -45,7 +45,7 @@ impl Command for Source {
     ) -> Result<PipelineData, ShellError> {
         // Note: this hidden positional is the block_id that corresponded to the 0th position
         // it is put here by the parser
-        let block_id: i64 = call.req(engine_state, stack, 1)?;
+        let block_id: i64 = call.req_parser_info(engine_state, stack, 0)?;
 
         let block = engine_state.get_block(block_id as usize).clone();
         eval_block(

crates/nu-command/src/env/source_env.rs

@@ -42,7 +42,7 @@ impl Command for SourceEnv {
 
         // Note: this hidden positional is the block_id that corresponded to the 0th position
         // it is put here by the parser
-        let block_id: i64 = call.req(engine_state, caller_stack, 1)?;
+        let block_id: i64 = call.req_parser_info(engine_state, caller_stack, 0)?;
 
         // Set the currently evaluated directory (file-relative PWD)
         let mut parent = if let Some(path) =

crates/nu-engine/src/call_ext.rs

@@ -34,6 +34,13 @@ pub trait CallExt {
         stack: &mut Stack,
         pos: usize,
     ) -> Result<T, ShellError>;
+
+    fn req_parser_info<T: FromValue>(
+        &self,
+        engine_state: &EngineState,
+        stack: &mut Stack,
+        pos: usize,
+    ) -> Result<T, ShellError>;
 }
 
 impl CallExt for Call {
@@ -99,4 +106,23 @@ impl CallExt for Call {
             ))
         }
     }
+
+    fn req_parser_info<T: FromValue>(
+        &self,
+        engine_state: &EngineState,
+        stack: &mut Stack,
+        pos: usize,
+    ) -> Result<T, ShellError> {
+        if let Some(expr) = self.parser_info_nth(pos) {
+            let result = eval_expression(engine_state, stack, expr)?;
+            FromValue::from_value(&result)
+        } else if self.parser_info.is_empty() {
+            Err(ShellError::AccessEmptyContent(self.head))
+        } else {
+            Err(ShellError::AccessBeyondEnd(
+                self.parser_info.len() - 1,
+                self.head,
+            ))
+        }
+    }
 }

crates/nu-engine/src/eval.rs

@@ -814,6 +814,7 @@ pub fn eval_element_with_input(
                             ],
                             redirect_stdout: false,
                             redirect_stderr: false,
+                            parser_info: vec![],
                         },
                         input,
                     )