Report only changes of send and received data #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey,
this patch adds a property that allows us to process only the sent and received data since the last request. This PR might be useful in the library mode. As each process has a limited lifetime, but might reappear with the same PID and/or name, it might happen, that a process drops from 1000 GB of sent or received data to 0.0001 GB, which is unnecessarily hard to deal with. However, if changes are reported, an app can deal with things more easily.
A use case is https://github.com/AndreasGocht/netgraph , which pushes the data from nethogs to an influx db, which can then be visualised using Grafana.
Best,
Andreas