Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated-features: Document the Deprecated features subsystem #2122

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

dumbbell
Copy link
Member

@dumbbell dumbbell commented Nov 6, 2024

The list of deprecated features is also documented in the release information section.

@dumbbell dumbbell requested a review from ansd November 6, 2024 17:47
@dumbbell dumbbell self-assigned this Nov 6, 2024
@dumbbell
Copy link
Member Author

dumbbell commented Nov 6, 2024

I will copy the article to v4.0 once the review process is finished.

Copy link

cloudflare-workers-and-pages bot commented Nov 6, 2024

Deploying rabbitmq-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5fd2176
Status: ✅  Deploy successful!
Preview URL: https://356267a4.rabbitmq-website.pages.dev
Branch Preview URL: https://document-deprecated-features.rabbitmq-website.pages.dev

View logs

@dumbbell dumbbell force-pushed the document-deprecated-features-subsystem branch from 2fbb6ce to db1cd10 Compare November 6, 2024 17:53

```ini
# Try RabbitMQ as if the deprecated feature was gone.
deprecated_features.permit.some_deprecated_feature = false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should list the names of such features in 3.13.x and 4.0.x.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, adding the list. Thank!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list is now available in a dedicated page at /docs/next/deprecated-features/list.

Copy link
Member

@ansd ansd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for writing this docs page!

Suggestions:

  1. Mention that there is also a Management UI tab for deprecated features.
  2. After this PR is merged, link to the new docs from the Management UI.

@dumbbell dumbbell force-pushed the document-deprecated-features-subsystem branch from db1cd10 to 01a2820 Compare November 6, 2024 18:47
@dumbbell
Copy link
Member Author

dumbbell commented Nov 6, 2024

Suggestions:

1. Mention that there is also a Management UI tab for deprecated features.

Done.

2. After this PR is merged, link to the new docs from the Management UI.

Ok, I will prepare a patch.

@dumbbell
Copy link
Member Author

dumbbell commented Nov 6, 2024

In fact, the list of deprecated features is global, not tied to a specific version of RabbitMQ. I will move it to src/pages.

Edit: I moved it to the release information section instead.

@dumbbell dumbbell force-pushed the document-deprecated-features-subsystem branch from 01a2820 to 8ae57a3 Compare November 7, 2024 08:17
The list of deprecated features is also documented in the release
information section.
@dumbbell dumbbell force-pushed the document-deprecated-features-subsystem branch from 8ae57a3 to 5fd2176 Compare November 7, 2024 08:24
@dumbbell dumbbell merged commit 5c96979 into main Nov 7, 2024
2 checks passed
@dumbbell dumbbell deleted the document-deprecated-features-subsystem branch November 7, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants