Clarify forever
channel declarations
#316
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current idiom
gives the impression that booleans will be sent through
forever
. Butthe channel never has anything sent through it; its purpose is just to
block indefinitely.
This PR clarifies the idiom in two ways:
bool
is replaced bystruct{}
– the unit type, as Go has nobottom type (empty type; ⊥) – clarifying that whatever may be sent
through the channel will never carry any information.
nil
– which always blocks whenread from or written to (see below) – clarifying that nothing at all
will ever be sent through it, leaving no doubts as to its purpose.
From the specification:
nil
channel is never ready for communication."nil
channel blocks forever."nil
channel blocks forever."