Skip to content

add ability to include properties to the consumers during subscriptions #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

DanielePalaia
Copy link
Contributor

At the moment it is not possible to include properties to Consumers.

These properties are passed during Subscriptions and are needed to implement some functionalities like the Single Active Consumer

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.73%. Comparing base (028f7e9) to head (290aa7d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
+ Coverage   88.08%   89.73%   +1.64%     
==========================================
  Files          78       78              
  Lines        6742     6748       +6     
==========================================
+ Hits         5939     6055     +116     
+ Misses        803      693     -110     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia DanielePalaia force-pushed the allow_setting_up_properties_in_producers_consumers branch from 8287525 to 290aa7d Compare November 7, 2024 09:27
@DanielePalaia DanielePalaia merged commit 2d26551 into main Nov 7, 2024
4 checks passed
@DanielePalaia DanielePalaia deleted the allow_setting_up_properties_in_producers_consumers branch November 7, 2024 13:44
@github-actions github-actions bot mentioned this pull request Nov 7, 2024
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants