Skip to content

Single active consumer implementation #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Nov 21, 2024
Merged

Conversation

DanielePalaia
Copy link
Contributor

@DanielePalaia DanielePalaia commented Nov 6, 2024

This closes #130

This PR implements the single active consumer functionality:

An example can be found in: examples/single_active_consumer/single_active_consumer_super_stream.rs

@DanielePalaia DanielePalaia marked this pull request as draft November 6, 2024 14:16
@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch 4 times, most recently from e544dc2 to c7189a3 Compare November 11, 2024 08:36
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 83.20611% with 44 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (2d26551) to head (4dc096a).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/consumer.rs 78.88% 19 Missing ⚠️
protocol/src/commands/consumer_update.rs 77.27% 10 Missing ⚠️
src/superstream_consumer.rs 79.48% 8 Missing ⚠️
protocol/src/response/mod.rs 71.42% 6 Missing ⚠️
protocol/src/request/mod.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #248      +/-   ##
==========================================
+ Coverage   89.33%   89.49%   +0.16%     
==========================================
  Files          78       80       +2     
  Lines        6748     7003     +255     
==========================================
+ Hits         6028     6267     +239     
- Misses        720      736      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch 4 times, most recently from 8b8266f to 0aba4b1 Compare November 11, 2024 10:35
@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch from 0aba4b1 to fc9578d Compare November 11, 2024 10:36
@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch from b2b8951 to d5b8869 Compare November 12, 2024 13:07
@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch from d5b8869 to ff83eb7 Compare November 12, 2024 13:07
@DanielePalaia DanielePalaia marked this pull request as ready for review November 13, 2024 08:44
@DanielePalaia
Copy link
Contributor Author

@Gsantomaggio @wolf4ood There can be still some improvements to do but we can start to review this one!

@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch from 345f435 to 7904411 Compare November 13, 2024 08:48
@DanielePalaia DanielePalaia force-pushed the sac_consumer_update_commands branch from a3f7a92 to 116193f Compare November 15, 2024 14:27
@DanielePalaia
Copy link
Contributor Author

@Gsantomaggio I think the suggestions have been addressed, back to you for review!

@DanielePalaia DanielePalaia changed the title Sac consumer update commands Single active consumer implementation Nov 19, 2024
@DanielePalaia
Copy link
Contributor Author

Discussing with @Gsantomaggio we can merge this one and improve the example in another PR

@DanielePalaia DanielePalaia merged commit 82f93ad into main Nov 21, 2024
3 of 4 checks passed
@DanielePalaia DanielePalaia deleted the sac_consumer_update_commands branch November 21, 2024 11:25
This was referenced Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement single active consumer for streams" (3.11 feature)
2 participants