Skip to content

fix a bug happening during sending of super_stream with routing_key #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

DanielePalaia
Copy link
Contributor

There is a bug in the routing_key mode of super_stream.

The cache for routes is not general but specific for a routing_key so it needs to be checked for every routing_key.

This PR should solve the issue.

It also adds an example for super_stream with routing_key mode.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (70e9844) to head (8b52d6d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   89.37%   89.70%   +0.32%     
==========================================
  Files          78       78              
  Lines        6741     6742       +1     
==========================================
+ Hits         6025     6048      +23     
+ Misses        716      694      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia DanielePalaia force-pushed the fix_bug_in_superstream_key_routing branch 2 times, most recently from 5932f36 to 2662a70 Compare November 5, 2024 08:43
@DanielePalaia DanielePalaia force-pushed the fix_bug_in_superstream_key_routing branch from e471203 to 8b52d6d Compare November 5, 2024 10:30
@DanielePalaia DanielePalaia merged commit b957d80 into main Nov 5, 2024
4 checks passed
@DanielePalaia DanielePalaia deleted the fix_bug_in_superstream_key_routing branch November 5, 2024 10:52
@Gsantomaggio Gsantomaggio added the bug Something isn't working label Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants