-
Notifications
You must be signed in to change notification settings - Fork 21
Add client properties #237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #237 +/- ##
==========================================
+ Coverage 88.92% 89.51% +0.58%
==========================================
Files 78 78
Lines 6662 6741 +79
==========================================
+ Hits 5924 6034 +110
+ Misses 738 707 -31 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio it looks good to me but I think we need to add this support for superstream too. It should be very similar to normal Producers/Consumers. At creation time of the superstream producers/consumers we can specify the client_provided_name and then propagate it when we create the producers in: https://github.com/rabbitmq/rabbitmq-stream-rust-client/blob/main/src/superstream_producer.rs#L69 Looks good if we want to do it in a different PR |
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@DanielePalaia How to change: let mut super_stream_producer = environment
.super_stream_producer(RoutingStrategy::HashRoutingStrategy(
HashRoutingMurmurStrategy {
routing_extractor: &hash_strategy_value_extractor,
},
))
.client_provided_name("my super stream producer for hello rust") // here you can change it |
Add client properties