Skip to content

close client connection in client consumer #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

DanielePalaia
Copy link
Contributor

I think in the Consumer part we create a client on line 97 which creates a connection:

 let mut client = self.environment.create_client().await?;

But then we create another one on line 123 without closing the previous one:

client = Client::connect(ClientOptions ....

Also in the close handle we don't close the locator connection.

This PR should solve the issue

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.35%. Comparing base (04e184b) to head (b1a4dd7).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/consumer.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   88.90%   90.35%   +1.45%     
==========================================
  Files          71       75       +4     
  Lines        6065     6801     +736     
==========================================
+ Hits         5392     6145     +753     
+ Misses        673      656      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DanielePalaia
Copy link
Contributor Author

@wolf4ood @Gsantomaggio

@DanielePalaia DanielePalaia merged commit f2aca24 into main Oct 30, 2024
3 of 4 checks passed
@DanielePalaia DanielePalaia deleted the close_client_in_consumer branch October 30, 2024 08:44
@github-actions github-actions bot mentioned this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants