Skip to content

fix(producer): publisher sequence #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

wolf4ood
Copy link
Collaborator

Fix #233 by incrementing of one unit the publisher sequence returned from the query

Fixed also some unused warning

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.07%. Comparing base (d705bfb) to head (396df20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
+ Coverage   88.90%   89.07%   +0.17%     
==========================================
  Files          75       75              
  Lines        6407     6408       +1     
==========================================
+ Hits         5696     5708      +12     
+ Misses        711      700      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wolf4ood
Copy link
Collaborator Author

@DanielePalaia @Gsantomaggio
Can you check on this?

Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge

@DanielePalaia DanielePalaia merged commit 656600b into rabbitmq:main Oct 28, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
@Gsantomaggio
Copy link
Member

Thank you @wolf4ood and @medigor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer<Dedup>: publishing_id incorrect
3 participants