Skip to content

Conversation

@Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jul 20, 2021

Fixes: #44

With this PR is possible to configure the client for load-balancer like:

addressResolver := AddressResolver{
			Host: "load-balancer-host",
			Port: load-balancer-port,
		}
		env, err := NewEnvironment(
			NewEnvironmentOptions().
				SetHost("localhost").
				SetPort(5552).
				SetAddressResolver(addressResolver).
				SetMaxProducersPerClient(1))
		Expect(err).NotTo(HaveOccurred())

Add mutex for race condition during close consumer
Add mutex for race condition during close consumer
@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2021

Codecov Report

Merging #61 (9380497) into main (8ed32be) will increase coverage by 1.20%.
The diff coverage is 84.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   78.67%   79.88%   +1.20%     
==========================================
  Files          16       16              
  Lines        1979     2023      +44     
==========================================
+ Hits         1557     1616      +59     
+ Misses        328      310      -18     
- Partials       94       97       +3     
Impacted Files Coverage Δ
pkg/stream/producer.go 81.15% <ø> (ø)
pkg/stream/enviroment.go 75.00% <75.86%> (-1.59%) ⬇️
pkg/stream/server_frame.go 74.82% <90.90%> (+5.86%) ⬆️
pkg/stream/client.go 78.80% <91.42%> (+0.71%) ⬆️
pkg/stream/brokers.go 94.73% <100.00%> (+0.21%) ⬆️
pkg/stream/consumer.go 83.09% <100.00%> (+0.24%) ⬆️
pkg/stream/coordinator.go 95.45% <100.00%> (+1.10%) ⬆️
pkg/stream/socket.go 83.33% <100.00%> (+0.98%) ⬆️
pkg/stream/constants.go 82.35% <0.00%> (+3.92%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04b01a...9380497. Read the comment docs.

@Gsantomaggio Gsantomaggio changed the title Fix http test Add Address Resolver Jul 22, 2021
@Gsantomaggio Gsantomaggio merged commit 14a4bfc into main Jul 23, 2021
@Gsantomaggio Gsantomaggio deleted the fix_test branch August 7, 2021 15:25
Zerpet added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

handle advertised_host and advertised_port

3 participants