Skip to content

Conversation

@Gsantomaggio
Copy link
Member

@Gsantomaggio Gsantomaggio commented Jul 16, 2021

fixes #57
fixes #60

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2021

Codecov Report

Merging #58 (4d9ac35) into main (89ba0a8) will increase coverage by 3.52%.
The diff coverage is 89.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   74.94%   78.47%   +3.52%     
==========================================
  Files          16       16              
  Lines        1956     1979      +23     
==========================================
+ Hits         1466     1553      +87     
+ Misses        395      330      -65     
- Partials       95       96       +1     
Impacted Files Coverage Δ
pkg/stream/constants.go 78.43% <ø> (ø)
pkg/stream/dialer_posix.go 53.84% <ø> (ø)
pkg/stream/client.go 77.65% <62.50%> (+0.17%) ⬆️
pkg/stream/producer.go 81.15% <80.00%> (+1.64%) ⬆️
pkg/stream/brokers.go 94.52% <100.00%> (+13.69%) ⬆️
pkg/stream/consumer.go 82.85% <100.00%> (+1.46%) ⬆️
pkg/stream/coordinator.go 94.35% <100.00%> (+0.06%) ⬆️
pkg/stream/enviroment.go 76.58% <100.00%> (+12.84%) ⬆️
pkg/stream/server_frame.go 68.96% <100.00%> (+2.52%) ⬆️
pkg/stream/socket.go 76.47% <0.00%> (-5.89%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89ba0a8...4d9ac35. Read the comment docs.

Gsantomaggio and others added 3 commits July 18, 2021 16:58
fixes: #60
Add enviroment tests
@Gsantomaggio Gsantomaggio changed the title WIP handle closing Handle Consumer closing Jul 18, 2021
@Gsantomaggio Gsantomaggio self-assigned this Jul 18, 2021
@Gsantomaggio Gsantomaggio merged commit 8ed32be into main Jul 18, 2021
@Gsantomaggio Gsantomaggio deleted the handle_consumer_close branch July 18, 2021 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Input Validation Consumer close gets stuck

3 participants