Skip to content

Conversation

@Gsantomaggio
Copy link
Member

Speed up a bit the tests

  • reduce the collect management time, it reduces the time to wait for the HTTP calls
  • remove some wait since there is already the wait_until function
  • remove the load definition and use the AMQP client to create the super-stream configuration

- reduce the collect management time, it reduces the time to wait the HTTP calls
- remove some wait since there is already the wait_until function
- remove the load definition and use the the AMQP client to create the super-stream configuration

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather remove commented code, we can always revert the commit if we want to "recover" this code.

@Gsantomaggio Gsantomaggio marked this pull request as draft September 21, 2023 15:43
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.13% 🎉

Comparison is base (20a43f3) 92.65% compared to head (a866c25) 92.79%.
Report is 1 commits behind head on main.

❗ Current head a866c25 differs from pull request most recent head 4edf0be. Consider uploading reports for the commit 4edf0be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
+ Coverage   92.65%   92.79%   +0.13%     
==========================================
  Files         112      112              
  Lines        9795     9804       +9     
  Branches      786      785       -1     
==========================================
+ Hits         9076     9098      +22     
+ Misses        547      536      -11     
+ Partials      172      170       -2     
Files Changed Coverage Δ
RabbitMQ.Stream.Client/Reliable/Producer.cs 83.92% <ø> (+2.53%) ⬆️
RabbitMQ.Stream.Client/RoutingClient.cs 94.25% <ø> (ø)
Tests/ReliableTests.cs 99.24% <100.00%> (-0.01%) ⬇️
Tests/UnitTests.cs 98.29% <100.00%> (ø)
Tests/Utils.cs 79.37% <100.00%> (+2.79%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Zerpet Zerpet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍

@Gsantomaggio Gsantomaggio marked this pull request as ready for review September 25, 2023 07:33
@Gsantomaggio Gsantomaggio merged commit 06294d5 into main Sep 25, 2023
@Gsantomaggio Gsantomaggio deleted the improve_test_speed branch September 25, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants