Improve the reconnect #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle some edge cases where the producer or consumer could go into a deadlock waiting for the semaphore. Add the Cancellation token producer side and call the token cancellation when the producer and the consumer are forced to disconnect. Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Codecov ReportBase: 92.30% // Head: 92.86% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 92.30% 92.86% +0.56%
==========================================
Files 95 96 +1
Lines 8343 8383 +40
Branches 653 654 +1
==========================================
+ Hits 7701 7785 +84
+ Misses 506 467 -39
+ Partials 136 131 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
| } | ||
|
|
||
| // Safe close | ||
| // the client can be closed only if the publishers are == 0 | ||
| // not a public method used internally by producers and consumers | ||
| internal CloseResponse MaybeClose(string reason) | ||
| internal async Task<CloseResponse> MaybeClose(string reason) |
| { | ||
| if (publishers.Count == 0 && consumers.Count == 0) | ||
| { | ||
| return Close(reason).Result; | ||
| await Close(reason).ConfigureAwait(false); |
|
@Gsantomaggio please see: #231 |
|
Should this token stay Though if the only situation where this happens is when end user calls |
…t and create producer (#231) * ConfigureAwait(false) for close stream, consumer, producer connections, query offset and create producer * Apply roslynator.exe fixes * Do not warn about ConfigureAwait in tests, fix more instances * Fixing ConfigureAwait(false) for the rest of the lib --------- Co-authored-by: Luke Bakken <luke@bakken.io>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
|
Thank you @iuribrindeiro @lukebakken @ricardSiliuk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle some edge cases where the producer or consumer could go into a deadlock waiting for the semaphore.
Add the Cancellation token producer side and call the token cancellation when the producer and the consumer are forced to disconnect.
I did this CaosTest for the stream client.
Where the connections are closed randomly.
Client should be able to reconnect and continue to produce and consume
Signed-off-by: Gabriele Santomaggio G.santomaggio@gmail.com