Skip to content

Conversation

@Hawxy
Copy link
Contributor

@Hawxy Hawxy commented Sep 9, 2022

Replaces usages of Wait with WaitAsync, & Thread.Sleep with Task.Delay.

Partially addresses #106

@codecov
Copy link

codecov bot commented Sep 9, 2022

Codecov Report

Merging #164 (c2847c2) into main (9e3e4f7) will decrease coverage by 0.26%.
The diff coverage is 98.11%.

@@            Coverage Diff             @@
##             main     #164      +/-   ##
==========================================
- Coverage   92.44%   92.17%   -0.27%     
==========================================
  Files          78       78              
  Lines        6125     6122       -3     
  Branches      378      378              
==========================================
- Hits         5662     5643      -19     
- Misses        376      391      +15     
- Partials       87       88       +1     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/Producer.cs 77.94% <75.00%> (-0.50%) ⬇️
RabbitMQ.Stream.Client/Consumer.cs 91.89% <100.00%> (+2.70%) ⬆️
RabbitMQ.Stream.Client/HeartBeatHandler.cs 100.00% <100.00%> (ø)
...bitMQ.Stream.Client/Reliable/IReconnectStrategy.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/Reliable/ReliableBase.cs 100.00% <100.00%> (ø)
...abbitMQ.Stream.Client/Reliable/ReliableConsumer.cs 98.68% <100.00%> (-0.02%) ⬇️
...abbitMQ.Stream.Client/Reliable/ReliableProducer.cs 86.90% <100.00%> (+0.07%) ⬆️
RabbitMQ.Stream.Client/RoutingClient.cs 98.61% <100.00%> (-0.06%) ⬇️
Tests/ReliableTests.cs 100.00% <100.00%> (ø)
Tests/UnitTests.cs 97.98% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukebakken lukebakken self-assigned this Sep 9, 2022
@lukebakken lukebakken added this to the 1.0.0-rc.6 milestone Sep 9, 2022
Copy link
Member

@Gsantomaggio Gsantomaggio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Contributor

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@lukebakken lukebakken merged commit 56c0e68 into rabbitmq:main Sep 12, 2022
@Gsantomaggio
Copy link
Member

Thank you @Hawxy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants