Skip to content

Conversation

@ricsiLT
Copy link
Contributor

@ricsiLT ricsiLT commented Jun 21, 2022

Make timeout configurable
Add some descriptions to enum cases

@codecov
Copy link

codecov bot commented Jun 21, 2022

Codecov Report

Merging #139 (207e7f9) into main (332edf8) will decrease coverage by 0.18%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   91.88%   91.69%   -0.19%     
==========================================
  Files          77       77              
  Lines        5815     5827      +12     
  Branches      358      359       +1     
==========================================
  Hits         5343     5343              
- Misses        386      398      +12     
  Partials       86       86              
Impacted Files Coverage Δ
...abbitMQ.Stream.Client/Reliable/ReliableProducer.cs 81.61% <53.84%> (-2.51%) ⬇️
...abbitMQ.Stream.Client/Reliable/ConfirmationPipe.cs 100.00% <100.00%> (ø)
Tests/ReliableTests.cs 100.00% <100.00%> (ø)
RabbitMQ.Stream.Client/WireFormatting.cs 70.50% <0.00%> (-4.32%) ⬇️
RabbitMQ.Stream.Client/Client.cs 91.39% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332edf8...207e7f9. Read the comment docs.

@Gsantomaggio
Copy link
Member

Can you please update the documentation? https://github.com/rabbitmq/rabbitmq-stream-dotnet-client#invalidate-messages.

Maybe explain the ClientSide exception vs server-side exception (ClientTimeoutError)

@Gsantomaggio Gsantomaggio added this to the 1.0.0-rc.4 milestone Jun 21, 2022
@Gsantomaggio Gsantomaggio merged commit e855dcd into rabbitmq:main Jun 21, 2022
@Gsantomaggio
Copy link
Member

Thank you @ricsiLT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants