Skip to content

Conversation

@Gsantomaggio
Copy link
Member

Fixes #125

Signed-off-by: Gabriele Santomaggio G.santomaggio@gmail.com

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #126 (928e35b) into main (62217de) will decrease coverage by 0.26%.
The diff coverage is 88.88%.

❗ Current head 928e35b differs from pull request most recent head 044e3a3. Consider uploading reports for the commit 044e3a3 to get more accurate results

@@            Coverage Diff             @@
##             main     #126      +/-   ##
==========================================
- Coverage   91.70%   91.44%   -0.27%     
==========================================
  Files          75       75              
  Lines        5668     5668              
  Branches      349      349              
==========================================
- Hits         5198     5183      -15     
- Misses        383      397      +14     
- Partials       87       88       +1     
Impacted Files Coverage Δ
RabbitMQ.Stream.Client/RoutingClient.cs 98.66% <87.50%> (-1.34%) ⬇️
Tests/UnitTests.cs 98.02% <100.00%> (ø)
RabbitMQ.Stream.Client/WireFormatting.cs 70.50% <0.00%> (-4.32%) ⬇️
RabbitMQ.Stream.Client/LogEventSource.cs 90.69% <0.00%> (-2.33%) ⬇️
RabbitMQ.Stream.Client/Client.cs 91.21% <0.00%> (-1.42%) ⬇️
Tests/ClientTests.cs 95.94% <0.00%> (-1.36%) ⬇️
RabbitMQ.Stream.Client/MetaData.cs 91.58% <0.00%> (+0.93%) ⬆️
RabbitMQ.Stream.Client/Subscribe.cs 65.21% <0.00%> (+1.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62217de...044e3a3. Read the comment docs.

@Gsantomaggio Gsantomaggio requested a review from lukebakken May 25, 2022 12:56
Fixes #125

Signed-off-by: Gabriele Santomaggio <G.santomaggio@gmail.com>
@Gsantomaggio Gsantomaggio force-pushed the validate_dns_issue_125 branch from 928e35b to 044e3a3 Compare May 25, 2022 13:02
@lukebakken lukebakken merged commit e4959cf into main May 25, 2022
@lukebakken lukebakken deleted the validate_dns_issue_125 branch May 25, 2022 13:14
@lukebakken
Copy link
Contributor

Feel free to create rc.3 with this change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DNS check when using loadbalancer with AddressResolver

4 participants