Max segment size #110
Merged
Max segment size #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #110 +/- ##
==========================================
+ Coverage 91.25% 91.46% +0.21%
==========================================
Files 69 69
Lines 4743 4755 +12
Branches 276 276
==========================================
+ Hits 4328 4349 +21
+ Misses 353 345 -8
+ Partials 62 61 -1
Continue to review full report at Codecov.
|
Gsantomaggio
requested changes
Apr 27, 2022
Member
Gsantomaggio
left a comment
Gsantomaggio
left a comment
There was a problem hiding this comment.
LGTM.
Can you please add the documentation to the README.md section (manage stream)?
Gsantomaggio
approved these changes
Apr 28, 2022
Gsantomaggio
approved these changes
Apr 28, 2022
Member
|
Thank you @simone-fariselli |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added configuration for MaxSegmentSizeBytes (issue #105)