Default to classic queues v2 #8308
Merged
+168
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuratczyk
force-pushed
the
default-to-cqv2
branch
4 times, most recently
from
8a1e93f to
6903427
Compare
PR based on the initial attempt: https://github.com/rabbitmq/rabbitmq-server/pull/7672/files
In mixed version cluster tests where the new node uses CQv2, when mirror synchronisation happens, v2 (source) overloads v1 (destination) leading to a memory spike and a crash (in a memory-constrained CI environment). Given that in 3.12 we switch to a lazy-like mode for all classic queues, I think we can make use a lazy queue in the test.
mkuratczyk
force-pushed
the
default-to-cqv2
branch
from
6903427 to
3c52f55
Compare
|
We've have decided to revert it because in certain specific scenarios, upgrading CQs at node boot time can be potentially unsafe (but doing the same thing after all nodes have been upgraded and rebooted is safe). Oh well. |
|
#10337 reverts the key part of this change. For now, one day CQv1 will be removed completely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the classic queue version default to 2 in preparation for 3.13.