Skip to content

Introduce a limit for how many virtual hosts can be created in a cluster #7798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 1, 2023
Merged

Introduce a limit for how many virtual hosts can be created in a cluster #7798

merged 7 commits into from
Apr 1, 2023

Conversation

@michaelklishin
Copy link
Collaborator

@michaelklishin michaelklishin commented Apr 1, 2023 •
edited
Loading

This is #7781 by @SimonUnge with a few tweaks from me:

  • Use an existing Cuttlefish validator
  • Use an error type we already use in similar places (for per-vhost limits but still)
  • Type specs

Closes #7777.

SimonUnge and others added 4 commits March 31, 2023 12:18
@SimonUnge
See #7777. Use vhost_max to stop vhost creation in rabbitmq
574ca55
@michaelklishin
Merge branch 'main' into sunge/max_vhost
947c0b7
@michaelklishin
vhost_max: add a Cuttlefish validator
1e4555b
@michaelklishin
Virtual host limit: error type naming
f1a922a 
vhost_precondition_failed => vhost_limit_exceeded

vhost_limit_exceeded is the error type used by
definition import when a per-vhost is exceeded.
It feels appropriate for this case, too.
@michaelklishin michaelklishin mentioned this pull request Apr 1, 2023
Merged
@michaelklishin michaelklishin merged commit 14bf921 into main Apr 1, 2023
@michaelklishin michaelklishin deleted the rabbitmq-server-7777 branch April 1, 2023 22:10
@mergify mergify bot mentioned this pull request Apr 1, 2023
Merged
michaelklishin added a commit that referenced this pull request Apr 1, 2023
@michaelklishin
Merge pull request #7800 from rabbitmq/mergify/bp/v3.12.x/pr-7798
de2082a 
Introduce a limit for how many virtual hosts can be created in a cluster (backport #7798)
@the-mikedavis the-mikedavis mentioned this pull request Jul 29, 2025
Merged
@mergify mergify bot mentioned this pull request Aug 7, 2025
Merged
@michaelklishin michaelklishin mentioned this pull request Aug 7, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Limit for the number of virtual hosts

3 participants

@michaelklishin @SimonUnge