Mark test deps as such #7463
Merged
Mark test deps as such #7463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This keeps other modules depending on rabbitmq-server from inheriting these deps
HoloRin
added a commit
that referenced
this pull request
Mar 1, 2023
* Mark test deps as dev_dependency in MODULE.bazel This keeps other modules depending on rabbitmq-server from inheriting these deps (cherry picked from commit faaf78b) * Further annotate test deps with new rules_erlang 3.9.9 features (cherry picked from commit 778ee99) * Mark rabbitmq_ct_helpers/rabbitmq_ct_client_helpers as testonly (cherry picked from commit 5cefbef) * Mark additional rules as testonly (cherry picked from commit ced6520) --------- Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com>
mergify bot
added a commit
that referenced
this pull request
Mar 1, 2023
* Mark test deps as dev_dependency in MODULE.bazel This keeps other modules depending on rabbitmq-server from inheriting these deps (cherry picked from commit faaf78b) * Further annotate test deps with new rules_erlang 3.9.9 features (cherry picked from commit 778ee99) * Mark rabbitmq_ct_helpers/rabbitmq_ct_client_helpers as testonly (cherry picked from commit 5cefbef) * Mark additional rules as testonly (cherry picked from commit ced6520) --------- Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com> (cherry picked from commit ce4ca48)
mergify bot
added a commit
that referenced
this pull request
Mar 1, 2023
* Mark test deps as dev_dependency in MODULE.bazel This keeps other modules depending on rabbitmq-server from inheriting these deps (cherry picked from commit faaf78b) * Further annotate test deps with new rules_erlang 3.9.9 features (cherry picked from commit 778ee99) * Mark rabbitmq_ct_helpers/rabbitmq_ct_client_helpers as testonly (cherry picked from commit 5cefbef) * Mark additional rules as testonly (cherry picked from commit ced6520) --------- Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com> (cherry picked from commit ce4ca48) (cherry picked from commit 67e6ef1) # Conflicts: # MODULE.bazel
HoloRin
pushed a commit
that referenced
this pull request
Mar 1, 2023
* Mark test deps as dev_dependency in MODULE.bazel This keeps other modules depending on rabbitmq-server from inheriting these deps (cherry picked from commit faaf78b) * Further annotate test deps with new rules_erlang 3.9.9 features (cherry picked from commit 778ee99) * Mark rabbitmq_ct_helpers/rabbitmq_ct_client_helpers as testonly (cherry picked from commit 5cefbef) * Mark additional rules as testonly (cherry picked from commit ced6520) --------- Co-authored-by: Rin Kuryloski <kuryloskip@vmware.com> (cherry picked from commit ce4ca48) (cherry picked from commit 67e6ef1) # Conflicts: # MODULE.bazel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend/update the declarations for some deps that are test only. This make it easier to ensure that no portion of those deps ends up in release artifacts
Requires rules_erlang 3.9.9, soon to be released