-
Notifications
You must be signed in to change notification settings - Fork 4k
Fix issue 7301 - broken vhost link #7304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
d97606e to
9ab7dca
Compare
michaelklishin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could reproduce the issue with 3.11.8 and this PR does address it.
lukebakken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
|
@Mergifyio backport v3.12.x v3.11.x |
✅ Backports have been created
|
|
thanks for the fix! could this be backported to 3.10.x as well? |
Fix issue 7301 - broken vhost link (backport #7304)
Fix issue 7301 - broken vhost link (backport #7304)
|
Automatic backport to Backporting this to |
|
thanks for the manual effort |
The root cause is that the templates that renders permissions and topic permissions within the vhost page assumes that the
usersattribute has a paged list of users (i.e. wrapped around anitemsattribute) however the attribute is just a plain array.Proposed Changes
Modified the affected templates to list users assuming they are just a plain array rather than an array under
items.Added selenium tests.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.mddocumentFurther Comments
Fixes #7301.