Skip to content

Conversation

@MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Feb 15, 2023

The root cause is that the templates that renders permissions and topic permissions within the vhost page assumes that the users attribute has a paged list of users (i.e. wrapped around an items attribute) however the attribute is just a plain array.

Proposed Changes

Modified the affected templates to list users assuming they are just a plain array rather than an array under items.
Added selenium tests.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

Fixes #7301.

@mergify mergify bot added the make label Feb 15, 2023
Copy link
Collaborator

@michaelklishin michaelklishin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could reproduce the issue with 3.11.8 and this PR does address it.

@michaelklishin michaelklishin removed this from the 3.11.10 milestone Feb 15, 2023
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

@michaelklishin michaelklishin merged commit 4ef9cbd into main Feb 15, 2023
@michaelklishin michaelklishin deleted the fix-7301-broken-link branch February 15, 2023 15:37
@michaelklishin
Copy link
Collaborator

@Mergifyio backport v3.12.x v3.11.x

@mergify
Copy link

mergify bot commented Feb 15, 2023

backport v3.12.x v3.11.x

✅ Backports have been created

@gomoripeti
Copy link
Contributor

thanks for the fix! could this be backported to 3.10.x as well?

michaelklishin added a commit that referenced this pull request Feb 15, 2023
Fix issue 7301 - broken vhost link (backport #7304)
michaelklishin added a commit that referenced this pull request Feb 15, 2023
Fix issue 7301 - broken vhost link (backport #7304)
michaelklishin added a commit that referenced this pull request Feb 15, 2023
Fix issue 7301 - broken vhost link (backport #7304) (backport #7314)
michaelklishin added a commit that referenced this pull request Feb 15, 2023
Fix issue 7301 - broken vhost link (backport #7304) (backport #7313)
michaelklishin added a commit that referenced this pull request Feb 15, 2023
…/pr-7314

Revert "Fix issue 7301 - broken vhost link (backport #7304) (backport #7314)"
@michaelklishin
Copy link
Collaborator

Automatic backport to v3.10.x introduces other regressions and had to be reverted.

Backporting this to v3.10.x would have to be manual.

michaelklishin added a commit that referenced this pull request Feb 15, 2023
michaelklishin added a commit that referenced this pull request Feb 15, 2023
@gomoripeti
Copy link
Contributor

thanks for the manual effort

MarcialRosales added a commit that referenced this pull request Feb 16, 2023
MarcialRosales added a commit that referenced this pull request Feb 16, 2023
@michaelklishin michaelklishin modified the milestone: 3.11.10 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browsing to a vhost by clicking on the name is broken

5 participants