Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gazelle for external erlang deps (backport #6935) #7029

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Use gazelle for external erlang deps (backport #6935) #7029

merged 2 commits into from
Jan 25, 2023

Commits on Jan 25, 2023

  1. Use gazelle for external erlang deps (#6935) 

    * Add gazelle for use with update-repos command

* Use explicit BUILD.app_name files for erlang app deps

This allows us to remove the duplicate definitions in
workspace_helpers.bzl

These files are generated with gazelle. For instance:
BUILD.ra is generated with `bazel run gazelle -- update-repos
--verbose --build_files_dir=bazel hex.pm/ra@2.4.6`

Running gazelle this way will modify the WORKSPACE file, as gazelle
does not yet support MODULE.bazel files. Such changes to the WORKSPACE
can be dropped, and should not be committed. It may also update the
`moduleindex.yaml` file. Changes to `moduleindex.yaml` should be
committed.

However
* skip the explicit bazel/BUILD.osiris file, as osiris already contains the file in its repo
* skip the explict BUILD.inet_tcp_proxy_dist file, since the repo already contains a bazel BUILD.bazel file
  gazelle command: `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel
inet_tcp_proxy_dist=github.com/rabbitmq/inet_tcp_proxy@master`
* jose is imported with `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel
jose=github.com/michaelklishin/erlang-jose@d63c1c5c8f9c1a4f1438e234b886de8607a0034e`

* Move the bats dep directly to WORKSPACE, drop workspace_helpers.bzl

* Use bzlmod in windows tests

(cherry picked from commit 2c7b37d)

# Conflicts:
#	workspace_helpers.bzl
    @HoloRin @mergify
    HoloRin authored and mergify[bot] committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    4869144 View commit details
    Browse the repository at this point in the history

  2. Fixup backport

    @HoloRin
    HoloRin committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    85346eb View commit details
    Browse the repository at this point in the history