Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gazelle for external erlang deps #6935

Merged
merged 19 commits into from
Jan 25, 2023
Merged

Use gazelle for external erlang deps #6935

merged 19 commits into from
Jan 25, 2023

Commits on Jan 24, 2023

  1. Use skylib 1.3.0

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b9683cf View commit details
    Browse the repository at this point in the history

  2. Add gazelle for use with update-repos command 

    For updating external erlang libraries
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    19ca1b2 View commit details
    Browse the repository at this point in the history

  3. Use explicit BUILD. files for hex deps 

    This allows us to remove the duplicate definitions in
workspace_helpers.bzl

These files are generated with gazelle. For instance:
BUILD.ra is generated with `bazel run gazelle -- update-repos
--verbose --build_files_dir=bazel hex.pm/ra@2.4.6`

Running gazelle this way will modify the WORKSPACE file, as gazelle
does not yet support MODULE.bazel files. Such changes to the WORKSPACE
can be dropped, and should not be committed. It may also update the
`moduleindex.yaml` file. Changes to `moduleindex.yaml` should be
committed.
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    46efad0 View commit details
    Browse the repository at this point in the history

  4. Update notes in BAZEL.md

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    5e274ba View commit details
    Browse the repository at this point in the history

  5. Force +debug_info for credentials_obfuscation 

    So that it can by dialyzed against
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    800a6cd View commit details
    Browse the repository at this point in the history

  6. Reorder statements in WORKSPACE 

    to try to fix some version collisions that seemed to load the wrong
gazelle version in some envs
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    413b03c View commit details
    Browse the repository at this point in the history

  7. Use explicit build_file for ct_helper

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    438e6b4 View commit details
    Browse the repository at this point in the history

  8. Use gazelle for jose dep

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b1da3b9 View commit details
    Browse the repository at this point in the history

  9. Use gazelle for emqtt dep

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    dfbc3e8 View commit details
    Browse the repository at this point in the history

  10. Use gazelle for meck dep

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0aec5b8 View commit details
    Browse the repository at this point in the history

  11. Use gazelle for proper dep

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1afcec9 View commit details
    Browse the repository at this point in the history

  12. Use gazelle for osiris 

    However, we skip the explicit bazel/BUILD.osiris file, as osiris
already contains the file in its repo
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    247a6ad View commit details
    Browse the repository at this point in the history

  13. Remove unneeded BUILD.jose file 

    As the correct one now lives in the bazel dir
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    ca8ef4d View commit details
    Browse the repository at this point in the history

  14. Use gazelle for inet_tcp_proxy_dist 

    But skip the explict BUILD.inet_tcp_proxy_dist file, since the repo
already contains a bazel BUILD.bazel file

gazelle command:
`bazel run gazelle -- update-repos --verbose --build_files_dir=bazel
inet_tcp_proxy_dist=github.com/rabbitmq/inet_tcp_proxy@master`
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e51c367 View commit details
    Browse the repository at this point in the history

  15. Move the bats dep directly to WORKSPACE, drop workspace_helpers.bzl 

    bats is a test dep, so need not be redeclared by bazel workspaces that
import rabbitmq-server
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    c919cdd View commit details
    Browse the repository at this point in the history

  16. Use bzlmod in windows tests

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9675151 View commit details
    Browse the repository at this point in the history

  17. WORKSPACE formatting

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0efe67f View commit details
    Browse the repository at this point in the history

  18. Re-import the correct jose with gazelle 

    `bazel run gazelle -- update-repos --verbose --build_files_dir=bazel
jose=github.com/michaelklishin/erlang-jose@d63c1c5c8f9c1a4f1438e234b886de8607a0034e`
    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    0dfee00 View commit details
    Browse the repository at this point in the history

  19. Use rules_erlang 3.9.1

    @HoloRin
    HoloRin committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    94ca2c0 View commit details
    Browse the repository at this point in the history