Skip to content

Update RabbitMQ Dashboards to support latest Grafana versions #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 24, 2022

Conversation

coro
Copy link
Contributor

@coro coro commented Aug 5, 2022

Proposed Changes

Grafana unofficially supports n-1 major versions, with the latest being, at time of writing, 9.0.6. This PR does the following:

  • Updates minimum Grafana versions on the dashboards to 8.3.4
    • This is not 8.0.0 because there were a handful of bugs which prevented some fields working
  • Migrates any dashboard panels on deprecated types to their new types
    • Graph (old) -> Time Series or Histogram (beta)
    • Table (old) -> Table
  • Fixes the distribution link graphs to work in Grafana 8&9
    • There was a bug in how the y-axis was rendered, meaning the entries for a peer were conflated
    • e.g. A->B and C->B were showing in the same row, leading to half the true amount of links
  • Fixes the RabbitMQ-Overview graph not displaying correctly on Grafana 9
    • Several graphs had the decimal option for the y-axis set to -1, which causes console errors in Grafana 9
  • Vastly simplified the process of updating the dashboards
    • The dashboards stored in this repo now match that which we upload to Grafana 1-1, rather than requiring us to inject fields like __inputs unnecessarily
    • The dashboards are now directly exported from Grafana with their Export functionality
    • Also added a README.md with a proposed process of how future updates work
  • Tweaked the 'latency distribution' graphs to use histogram formats instead
    • This improves their readability compared with the old graph style

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Put an x in the boxes that apply.
You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass locally with my changes
  • If relevant, I have added necessary documentation to https://github.com/rabbitmq/rabbitmq-website
  • If relevant, I have added this change to the first version(s) in release-notes that I expect to introduce it

Further Comments

I have tested this on Grafana versions 3.8.4 and 9.0.6, through both the make targets in the repo and on a seperate Kubernetes cluster running the kube-prometheus stack.

This is part of a wider change to update the dashboards in this issue. The next step is to migrate the metrics from aggregated metrics to the more accurate global metrics as per #3127 (comment)

@mergify mergify bot added the make label Aug 5, 2022
@ikavgo ikavgo self-requested a review August 11, 2022 21:21
@ikavgo
Copy link
Contributor

ikavgo commented Aug 24, 2022

I think it is safe to merge this one. README script works, no errors on dashboards, they look clean and native grafana export produces exactly same json as in the repo (ignoring version bump of course).

@ikavgo ikavgo merged commit e15d12d into main Aug 24, 2022
@michaelklishin michaelklishin deleted the grafana-9-support branch August 25, 2022 01:32
@michaelklishin
Copy link
Collaborator

@Mergifyio backport v3.11.x v3.10.x v3.9.x

@mergify
Copy link

mergify bot commented Aug 25, 2022

backport v3.11.x v3.10.x v3.9.x

✅ Backports have been created

@michaelklishin michaelklishin added this to the 3.10.8 milestone Aug 25, 2022
michaelklishin added a commit that referenced this pull request Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
michaelklishin added a commit that referenced this pull request Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
michaelklishin added a commit that referenced this pull request Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants