-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Update RabbitMQ Dashboards to support latest Grafana versions #5449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both directions of the link were showing as one entry instead of two. This is beacuse of flant/grafana-statusmap#277
'-1' is no longer accepted as of Grafana 9, and causes a console error when rendering
12 tasks
I think it is safe to merge this one. README script works, no errors on dashboards, they look clean and native grafana export produces exactly same json as in the repo (ignoring version bump of course). |
@Mergifyio backport v3.11.x v3.10.x v3.9.x |
This was referenced Aug 25, 2022
✅ Backports have been created
|
michaelklishin
added a commit
that referenced
this pull request
Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
michaelklishin
added a commit
that referenced
this pull request
Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
michaelklishin
added a commit
that referenced
this pull request
Aug 25, 2022
Update RabbitMQ Dashboards to support latest Grafana versions (backport #5449)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Grafana unofficially supports
n-1
major versions, with the latest being, at time of writing, 9.0.6. This PR does the following:Graph (old)
->Time Series
orHistogram (beta)
Table (old)
->Table
peer
were conflateddecimal
option for the y-axis set to-1
, which causes console errors in Grafana 9__inputs
unnecessarilyTypes of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply.You can also fill these out after creating the PR.
If you're unsure about any of them, don't hesitate to ask on the mailing list.
We're here to help!
This is simply a reminder of what we are going to look for before merging your code.
CONTRIBUTING.md
documentFurther Comments
I have tested this on Grafana versions 3.8.4 and 9.0.6, through both the make targets in the repo and on a seperate Kubernetes cluster running the kube-prometheus stack.
This is part of a wider change to update the dashboards in this issue. The next step is to migrate the metrics from aggregated metrics to the more accurate global metrics as per #3127 (comment)