Skip to content

Validate amqp0.9.1 queue name length in management UI #3202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

deadtrickster
Copy link
Contributor

Proposed Changes

Validate AMQP 0.9.1 queue name length when creating queue directly in Management UI on Queues tab or indirectly when moving messages to the new queue.

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (potentially 🤷‍♂️)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

Further Comments

I wasn't sure what to do here for the sake of consistency (and given the fact that unicode eats bytes) - either drop limit in the frames completely or make Management UI validate it. Luckily shovel plugin has this separate module for 0.9.1 shovels and queue creation in Management UI goes via 0.9.1 framing too. So the new validation is scoped to 0.9.1.

@michaelklishin michaelklishin merged commit 4ba8d05 into master Jul 19, 2021
@michaelklishin michaelklishin deleted the validate-amqp0-9-1-queue-name-length-in-management-ui branch July 19, 2021 18:57
michaelklishin added a commit that referenced this pull request Jul 19, 2021
…length-in-management-ui

Validate amqp0.9.1 queue name length in management UI

(cherry picked from commit 4ba8d05)
michaelklishin added a commit that referenced this pull request Jul 19, 2021
…length-in-management-ui

Validate amqp0.9.1 queue name length in management UI

(cherry picked from commit 4ba8d05)
@michaelklishin
Copy link
Collaborator

Backported to v3.8.x.

@michaelklishin
Copy link
Collaborator

Backported to v3.9.x.

@michaelklishin michaelklishin added this to the 3.8.20 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants