OTP 24 compat: switch management and management_agent to use pg #2850
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since pg2 was removed in OTP 24. The only decision worth mentioning here is that both plugins share a pg scope, which is started in rabbitmq_management_agent supervision tree and idempotently started in rabbitmq_management without attaching the scope pid to its tree. Per discussion with @lhoguin.
lhoguin
requested changes
Feb 26, 2021
deps/rabbitmq_management_agent/src/rabbit_mgmt_agent_sup_sup.erl
Outdated
Show resolved
Hide resolved
lhoguin
approved these changes
Feb 26, 2021
|
For as long as we support Erlang 22, we'd have to keep this 3.9-specific. After Erlang 22 support is dropped, we can backport this. |
luos
added a commit
to luos/rabbitmq-server
that referenced
this pull request
May 14, 2021
Previously the restart intensity was 100 and period 50. This process was prone to crashing in the past, so it does not make sense to not restart it if anything happens during the gathering of statistics. Related: rabbitmq#2850
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since pg2 was removed in OTP 24.
The only decision worth mentioning here is that both plugins share
a pg scope, which is started in rabbitmq_management_agent supervision
tree and idempotently started in rabbitmq_management without
attaching the scope pid to its tree.
Per discussion with @lhoguin.