Revert "Remove dead_queue_rejects test flake" #2325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9772aa8. Check RPC return value Try a cast to fix test
lukebakken
force-pushed
the
revert-rabbitmq-server-2308-dead_queue_rejects
branch
from
c8b9c2b to
53cc7b4
Compare
lukebakken
changed the title
lukebakken
changed the title
dumbbell
approved these changes
Apr 27, 2020
lukebakken
pushed a commit
that referenced
this pull request
Apr 27, 2020
…ad_queue_rejects Revert "Remove dead_queue_rejects test flake" (cherry picked from commit 55d28f5)
|
👍 |
lukebakken
added a commit
that referenced
this pull request
Apr 30, 2020
…-2308-dead_queue_rejects" This reverts commit 9b80b9c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 9772aa8
Changing from
amqp_channel:calltoamqp_channel:castallows the operation to complete before a new queue process is started, resulting in the expectedbasic.nackresponse.